Conversation
…-add-right-menu-highlight
…-add-right-menu-highlight
|
Here's the code health analysis summary for commits Analysis Summary
|
|
igoroctaviano
left a comment
There was a problem hiding this comment.
This looks like a bigger change and involves a good amount of event handling. I'll be testing it later today. Thx.
|
|
||
| console.debug(`selected ROI "${selectedRoi.uid}"`) | ||
|
|
||
| if (!this.keysDown.has('Shift')) { |
There was a problem hiding this comment.
Can you document why this change?
There was a problem hiding this comment.
I'm allowing the user to select multiple features on the right side panel. If they just click a feature in the right side panel, then the feature is selected but all of the other features are unselected.
However, if they maintain the shift key pressed, they'll just add the clicked feature to the selected list and won't remove the other ones.
It's a UX improvement.
|
@pedrokohler, it's a big change. Can you describe in the PR how to test it and what to expect? Also, look at deep source issues. |
|
Adding highlight to the right menu/panel so that it matches the selected ROIs.
Solves: #196
WARNING: Needs ImagingDataCommons/dicom-microscopy-viewer#175 to be merged first.