Only create mods and temp directories when needed#226
Merged
ManlyMarco merged 2 commits intomasterfrom Oct 18, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes directory creation by deferring the creation of the mods and temp directories until they are actually needed, rather than creating them during initialization. The property ModsPath has been renamed to ZipmodsPath to better reflect its purpose of storing zipmod files.
Key changes:
- Renamed
ModsPathtoZipmodsPaththroughout the codebase for clarity - Changed directory initialization from
Directory.CreateDirectory()tonew DirectoryInfo()formodsandtempdirectories to avoid creating them unnecessarily - Added existence checks before accessing these directories to prevent errors when they don't exist yet
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/KKManager.Core/Functions/InstallDirectoryHelper.cs | Renamed ModsPath to ZipmodsPath and changed initialization to use DirectoryInfo constructor instead of creating directories |
| src/KKManager.Core/Data/Zipmods/SideloaderModLoader.cs | Updated reference from ModsPath to ZipmodsPath |
| src/KKManager.Core/Functions/ModInstaller.cs | Updated reference from ModsPath to ZipmodsPath |
| src/KKManager.Updater/Windows/ModUpdateProgressDialog.cs | Added existence checks before accessing PluginPath and ZipmodsPath directories |
| src/KKManager/Windows/MainWindow.cs | Updated reference from ModsPath to ZipmodsPath |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.