Implement LocalTextures API#93
Merged
ManlyMarco merged 19 commits intoIllusionMods:masterfrom Oct 27, 2025
Merged
Conversation
AI / HS2 todo
There was a problem hiding this comment.
Pull Request Overview
This PR implements a new LocalTextures API that allows plugins to control how textures are saved with character cards and studio scenes. The API provides three save modes: bundled (embedded in the file), deduped (shared between objects in studio), and local (saved separately to reduce file size but prevent sharing).
Key Changes:
- Added
TextureSaveTypeenum defining three texture save modes - Created
LocalTexturesAPI classes for Maker and Studio contexts with UI controls - Implemented
LocalSaveChangedEventArgsfor change notifications - Added embedded UI resources for the texture save type selector interface
Reviewed Changes
Copilot reviewed 14 out of 22 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Shared.Core/TextureSaveType.cs | Defines enum for texture save type options |
| src/Shared.Core/Events/LocalSaveChangedEventArgs.cs | Event args for save type changes |
| src/Shared.Core/Maker/LocalTextures.cs | Core Maker API implementation with UI setup |
| src/Shared.KKalike/Maker/LocalTextures.cs | KK-specific Maker UI implementation |
| src/Shared.AIalike/Maker/LocalTextures.cs | AI-specific Maker UI implementation |
| src/Shared.CharaStudio/Studio/LocalTextures.cs | Studio API with scene save UI |
| src/PHAPI/*.cs | PH-specific implementations |
| *.projitems | Project file updates adding new source files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ManlyMarco
requested changes
Oct 27, 2025
Collaborator
ManlyMarco
left a comment
There was a problem hiding this comment.
Mostly good, using the same name for different APIs that do different but similar things is a bad idea though, it will get confusing fast.
ManlyMarco
reviewed
Oct 27, 2025
…e start Co-authored-by: ManlyMarco <39247311+ManlyMarco@users.noreply.github.com>
ManlyMarco
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.