Added dropdowns and colorpickers to the SceneEffectCategory stuff.#77
Merged
ManlyMarco merged 6 commits intoIllusionMods:masterfrom Sep 17, 2024
krypto5863:master
Merged
Added dropdowns and colorpickers to the SceneEffectCategory stuff.#77ManlyMarco merged 6 commits intoIllusionMods:masterfrom krypto5863:master
ManlyMarco merged 6 commits intoIllusionMods:masterfrom
krypto5863:master
Conversation
ManlyMarco
requested changes
Sep 12, 2024
Collaborator
ManlyMarco
left a comment
There was a problem hiding this comment.
The changes look good, but whitespace got messed up with random tabs. Make sure your editor is set to using spaces for indents.
Contributor
Author
|
Should be fixed now, I'm a tab enjoyer. Might add a few more controls to this later. |
Collaborator
|
Do you want me to wait with reviewing until you finish adding them? You can mark the PR as a draft in that case. |
Contributor
Author
|
Nah should be good to go now. Think I've done most of the simple stuff with this already. |
ManlyMarco
reviewed
Sep 17, 2024
Great idea Co-authored-by: ManlyMarco <39247311+ManlyMarco@users.noreply.github.com>
ManlyMarco
reviewed
Sep 17, 2024
ManlyMarco
approved these changes
Sep 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Threw these together real quick, I only tested in HS2 and KKS, so lemme know if fixes or changes need to be made.