Conversation
|
@ViktorSlavov Although it's a little bit late for test-driven, my suggestion is to catch up on unit tests now and to implement the rest with a test-driven approach! |
d22e523 to
409b3e2
Compare
6bbe579 to
b7106b9
Compare
2afd38f to
de7b239
Compare
| * const children: IgxTreeNode<any>[] = node.children; | ||
| * ``` | ||
| */ | ||
| public get _children(): IgxTreeNode<any>[] { |
There was a problem hiding this comment.
Should the public getter be with _?
There was a problem hiding this comment.
This will be change once all functionality is implemented - we'll remove the _ and swap this w/ the current children: QueryList<IgxTreeNode<any>> property. I've left a TODO comment above the API docs for this one.
There's currently a children: QueryList<IgxTreeNode> property, which is /** @hidden @internal */ and is used in the logic for selection and navigation.
| * ``` | ||
| */ | ||
| @Input() | ||
| public get expanded() { |
There was a problem hiding this comment.
Also you need expandedChange for [(expanded)] binding.
There was a problem hiding this comment.
My mistake, I've added that
| * ``` | ||
| */ | ||
| @Input() | ||
| public get selected(): boolean { |
There was a problem hiding this comment.
Also you need selectedChange for [(selected)] binding.
There was a problem hiding this comment.
One was implemented w/ the selection service, it's at the start of the class definition (to avoid making lint angry)
projects/igniteui-angular/src/lib/expansion-panel/toggle-animation-component.spec.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/expansion-panel/toggle-animation-component.ts
Show resolved
Hide resolved
| } | ||
|
|
||
| // Enums | ||
| export const IGX_TREE_SELECTION_TYPE = mkenum({ |
Closes #7475
Closes #9092
IgxTree Implementation
Spec
IgxExpansionPanelclass to reuse of animation codeIgxExpansionPanel)igxTreeNodeLinkdirective + rolesAdditional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)