Skip to content

Input Group: Change styling implicitly based on theme, not type#7990

Merged
simeonoff merged 10 commits intomasterfrom
simeonoff/input-group-refactor
Aug 20, 2020
Merged

Input Group: Change styling implicitly based on theme, not type#7990
simeonoff merged 10 commits intomasterfrom
simeonoff/input-group-refactor

Conversation

@simeonoff
Copy link
Collaborator

@simeonoff simeonoff commented Aug 13, 2020 •
edited
Loading

Closes #

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

IgniteUI/igniteui-angular-samples#2204
IgniteUI/igniteui-docfx#2172

@StefanIvanov StefanIvanov linked an issue Aug 14, 2020 that may be closed by this pull request
Expose way to set the Input Group type globally since input components depend on it to apply themes correctly. #6751
Closed
@simeonoff simeonoff added the ❌ status: awaiting-test PRs awaiting manual verification label Aug 18, 2020
@simeonoff simeonoff marked this pull request as ready for review August 18, 2020 09:57
damyanpetev
damyanpetev requested changes Aug 19, 2020
View reviewed changes
Copy link
Member

@damyanpetev damyanpetev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mainly due to window reference

@simeonoff simeonoff force-pushed the simeonoff/input-group-refactor branch from a7a6341 to 78405ca Compare August 19, 2020 14:29
@simeonoff simeonoff requested a review from damyanpetev August 19, 2020 14:39
damyanpetev
damyanpetev previously approved these changes Aug 19, 2020
View reviewed changes
@simeonoff simeonoff merged commit 5510563 into master Aug 20, 2020
@simeonoff simeonoff deleted the simeonoff/input-group-refactor branch August 20, 2020 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damyanpetev damyanpetev damyanpetev approved these changes

@desig9stein desig9stein desig9stein approved these changes

Assignees

@SAndreeva SAndreeva

Labels

input-group refactoring version: 10.2.x ❌ status: awaiting-test PRs awaiting manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expose way to set the Input Group type globally since input components depend on it to apply themes correctly.

4 participants

@simeonoff @damyanpetev @desig9stein @SAndreeva