Conversation
Contributor
Author
|
Work on this PR will resume after 9.1.x |
…imepicker-disabled-values
…abled-values' of https://github.com/IgniteUI/igniteui-angular into valadzhov/fix-3978-different-styling-for-timepicker-disabled-values
PlamenaMiteva
previously approved these changes
Jul 3, 2020
jackofdiamond5
requested changes
Jul 6, 2020
projects/igniteui-angular/src/lib/time-picker/time-picker.component.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/time-picker/time-picker.component.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/time-picker/time-picker.component.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/time-picker/time-picker.directives.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/time-picker/time-picker.directives.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/time-picker/time-picker.directives.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/time-picker/time-picker.directives.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/time-picker/time-picker.directives.ts
Outdated
Show resolved
Hide resolved
jackofdiamond5
previously approved these changes
Jul 7, 2020
jackofdiamond5
previously approved these changes
Jul 7, 2020
Lipata
suggested changes
Jul 8, 2020
Contributor
Lipata
left a comment
There was a problem hiding this comment.
Let's try and move all the applyDisabledStyleForXXX properties in the time-picker component instead of having then in individual directives. This will save passing the same properties for all the directives (selectedHour, etc.). You can use the [ngClass] for setting the appropriate class.
Lipata
suggested changes
Jul 8, 2020
Contributor
Lipata
left a comment
There was a problem hiding this comment.
You can update the changelog.
…abled-values' of https://github.com/IgniteUI/igniteui-angular into valadzhov/fix-3978-different-styling-for-timepicker-disabled-values
Lipata
approved these changes
Jul 14, 2020
jackofdiamond5
approved these changes
Jul 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3978
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)