Skip to content

Python 3.5 compatibility broken #749

@clokep

Description

@clokep

I'm not sure if this was done on purpose or not, but 5cdd5c4 included changes that are not compatible with Python 3.5:

builtins.SyntaxError: invalid syntax (client.py, line 53)

I believe the comma at the end of **kwargs is invalid.

Code Version

6.4.0

Expected Behavior

6.4.0 should either work on Python 3.5 or not install on Python 3.5.

Current Behavior

Trying to use pysaml2 on Python 3.5 errors.

Possible Solution

  • Use python_requires in setup.py / setup.cfg to state that pysaml2 does not support Python 3.5.
  • Fix the syntax error so Python 3.5 can use pysaml2.

Steps to Reproduce

Using Python 3.5:

>>> from saml2.client import Saml2Client
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/clokep/.pyenv/versions/synapse-3.5/lib/python3.5/site-packages/saml2/client.py", line 53
    **kwargs,
            ^
SyntaxError: invalid syntax

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions