Merged
Conversation
onyxraven
commented
Sep 28, 2022
| } | ||
|
|
||
| if _, err := file.WriteString(line); err != nil { | ||
| if _, err := file.WriteString(line + "\n"); err != nil { |
Member
Author
There was a problem hiding this comment.
prefers adding the newline.
| t.Run("missing gitignore file", func(t *testing.T) { | ||
| tempFilePath := t.TempDir() + "/.gitignore" | ||
| if _, err := os.Stat(tempFilePath); err == nil { | ||
| t.Errorf("RemoveFileFromIgnored() = gitignore accidentally exists") |
Member
Author
There was a problem hiding this comment.
specifically test that we're not using some leftover from another test
onyxraven
commented
Sep 28, 2022
| } | ||
|
|
||
| if _, err := os.Stat(tempFilePath); err == nil { | ||
| t.Errorf("RemoveFileFromIgnored() = gitignore exists when it should not") |
Member
Author
There was a problem hiding this comment.
ensure we didn't accidentally do something to the file (which still shouldn't exist)
| t.Run(tt.name, func(t *testing.T) { | ||
| tempFilePath := t.TempDir() + "/.gitignore" | ||
| err := os.WriteFile(tempFilePath, tt.gitIgnoreContent, 0644) | ||
| err := os.WriteFile(tempFilePath, tt.gitIgnoreContent, 0600) |
Member
Author
There was a problem hiding this comment.
linter wanted this, and in a test, this makes sense
| } | ||
| } | ||
|
|
||
| func TestAddFileNoExistingFile(t *testing.T) { |
elementalvoid
approved these changes
Oct 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Adds a few 'no gitignore' tests. Followup of #50
Also prefers to add a newline at the end of the gitignore.
Versioning
batched up in the next release
Tasks
/cc
@randrusiak