Merged
Conversation
add5586 to
ed93e5d
Compare
onyxraven
commented
Sep 6, 2022
.github/workflows/release.yaml
Outdated
| args: release --rm-dist | ||
| env: | ||
| # this needs push access to the tap | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
Member
Author
There was a problem hiding this comment.
will add these. this one has to be a PAT to access the other repo :/
Contributor
There was a problem hiding this comment.
You may need to use a different secret name. secrets.GITHUB_TOKEN is a "special" secret that GH Actions auto-creates for every build. I'm not sure what it does is the names conflict.
elementalvoid
previously approved these changes
Sep 6, 2022
1b40489 to
819077c
Compare
819077c to
e1604f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to use github actions. Along the way this fixes some internal things to do around security and such.
fixes #48
Versioning
should be none required, but will need a release cut to ensure the release workflow works.
Tasks