Add proper .sops extension for file without extension#51
Merged
onyxraven merged 3 commits intoIbotta:masterfrom Sep 7, 2022
randrusiak:fix/normalize-to-sops-file-without-extension
Merged
Add proper .sops extension for file without extension#51onyxraven merged 3 commits intoIbotta:masterfrom randrusiak:fix/normalize-to-sops-file-without-extension
onyxraven merged 3 commits intoIbotta:masterfrom
randrusiak:fix/normalize-to-sops-file-without-extension
Conversation
onyxraven
approved these changes
Sep 7, 2022
Member
onyxraven
left a comment
There was a problem hiding this comment.
added a couple test cases to test the 'other' direction
tested locally and works. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Story/Issue Link
Fixes #11
Background
Currently, if you add a file without an extension then ".sops" extension is added as a prefix. It looks strange and disallows adding a file with a local path for example ./file_no_ext.
I added a simple conditional which handle this case :)
Versioning
Patch version
Additional Requests to Reviewers
Tasks