Add updatekeys command#49
Merged
onyxraven merged 1 commit intoIbotta:masterfrom Sep 6, 2022
randrusiak:feature/add-updatekeys-command
Merged
Add updatekeys command#49onyxraven merged 1 commit intoIbotta:masterfrom randrusiak:feature/add-updatekeys-command
onyxraven merged 1 commit intoIbotta:masterfrom
randrusiak:feature/add-updatekeys-command
Conversation
onyxraven
reviewed
Aug 25, 2022
Member
onyxraven
left a comment
There was a problem hiding this comment.
Thanks for the submission!
It's been a little bit since I've worked on this package so I'm going to review this in a bit more depth later but at first glance it looks like a clean update. I'll ensure this gets tested, etc.
(It looks like our travis config broke, so I may need to do a migration to actions before I get this out).
onyxraven
approved these changes
Sep 6, 2022
Member
onyxraven
left a comment
There was a problem hiding this comment.
ran locally and everything looks good. Thanks!
Contributor
Author
|
Thank you too! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Story/Issue Link
Fixes #23 -- shortcut to update the KMS keys and rotate all files
Background
I started using sopstool and I noticed that the updatekeys command is missing. So I decided to implement it on my own.
Firstly I was thinking about combining it with rotate command but I found that sops maintainers recommend keeping these commands separated. getsops/sops#365 (comment)
It's my first PR in this project so let me know if i did something wrong :)
Versioning
v1.1.0
Additional Requests to Reviewers
Tasks