-
Notifications
You must be signed in to change notification settings - Fork 5
Closed as not planned
Closed as not planned
Copy link
Labels
enhancementNew feature or requestNew feature or request
Description
Current Behavior
Currently, we recommend installing sopstool via the install.sh script. This installs sops first before installing sopstool. I believe we should instead ask the user to install sops themselves. Other popular wrapper tools like terragrunt or saml2aws do this to simplify management of their tool. I propose we:
- Remove the install scripts (install.sh, sopsinstall.sh, sopstoolinstall.sh).
- Adjust Travis by downloading (via curl?) a copy of sops 3.7.2 or later directly from the release during the build process.
- Adjust the Dockerfile to do the same when we build the image.
- Ask the user to install sops as a dependency.
While the scripts themselves aren't a ton of maintenance, it'll just be less the maintain. I'm stuck between hard coding 3.7.2 into Travis or the Dockerfile, or just saying "install sops" and worrying about compatibility ourselves though.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request