Skip to content

Wrap the always-visible textControl in a PanelBody so that it has the correct padding #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
benlk merged 2 commits into from
Mar 21, 2020
Merged

Wrap the always-visible textControl in a PanelBody so that it has the correct padding #74

benlk merged 2 commits into from
Mar 21, 2020

Conversation

@benlk
Copy link
Collaborator

@benlk benlk commented Mar 20, 2020 •
edited by joshdarby
Loading

Changes

This pull request makes the following changes:

  • Wraps the non-advanced controls in a PanelBody element so that the Pym.js Child URL control doesn't overflow its container
  • Bumps "Tested up to:" to 5.4.
  • Starts changelog for the [next] release, which will likely be 1.3.2.4.

Before:

Screen Shot 2020-03-19 at 19 07 23

After:

Screen Shot 2020-03-19 at 22 18 22

Why

For #72, fixing a visual regression in WP 5.4

Testing/Questions

Features that this PR affects:

  • the block inspector controls

Questions that need to be answered before merging:

Steps to test this PR:

  1. View a Pym.js Embeds block's sidebar controls under master, and under this branch.

@benlk benlk requested a review from joshdarby March 20, 2020 02:22
@benlk benlk self-assigned this Mar 20, 2020
@joshdarby
Copy link

joshdarby commented Mar 20, 2020

@benlk Do you think we need to update the version number so we don't run into the issue we did when updating SCAIP?

@benlk
Copy link
Collaborator Author

benlk commented Mar 20, 2020

We do need to do that, but I was going to do that in a separate PR.

joshdarby
joshdarby approved these changes Mar 20, 2020
View reviewed changes
Copy link

@joshdarby joshdarby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected.

@benlk benlk merged commit 3de3cf4 into master Mar 21, 2020
@benlk benlk mentioned this pull request Mar 21, 2020
Closed
42 tasks
@benlk benlk added this to the Version 1.3.2.4 milestone Mar 24, 2020
@benlk benlk mentioned this pull request Mar 26, 2020
Merged
2 tasks
@benlk benlk deleted the 72-visual-fixes branch March 26, 2020 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@joshdarby joshdarby joshdarby approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@benlk benlk

Labels

priority: low type: bug type: improvement

Projects

None yet

Milestone

1.3.2.4

Development

Successfully merging this pull request may close these issues.

3 participants

@benlk @joshdarby