hiding stacktrace for DOSDPError instances #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balhoff
reviewed
Feb 19, 2021
Member
balhoff
left a comment
There was a problem hiding this comment.
I think this looks good! Two questions:
- Should we move your catchSome/catchAllCause to Main so it's not repeated?
- Does this still give a failure Unix exit code for DOSDPError? I think I had an issue with this in boomer and had to complicate it a little bit. Here's what I did there: https://github.com/INCATools/boomer/blob/f65b5b577037d5d25d8dd63a8531cf375af0d618/src/main/scala/org/monarchinitiative/boomer/Main.scala#L68-L73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.