This repository was archived by the owner on Jul 3, 2025. It is now read-only.
Fix jsonld label error#24
Merged
Merged
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seems to have been an issue since
v2.0.4, at least in the umd version, where if the__jsonldproperty doesn't exist on line 109 the switch from the default view to date grouping will fail.This PR adds an additional check to the
if()to ensure it does before attempting to check/use.labelAdditionally the example
index.htmlfile is changed to use an appropriate manifest for testing purposes.I've not used optional chaining because the TS version doesn't seem to support it, but that's a separate issue.