Skip to content

Block Triangularization skip_final_solve option #1711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dallan-keylogic merged 4 commits into from
Nov 24, 2025
Merged

Block Triangularization skip_final_solve option #1711

dallan-keylogic merged 4 commits into from
Nov 24, 2025

Conversation

@dallan-keylogic
Copy link
Contributor

@dallan-keylogic dallan-keylogic commented Nov 21, 2025

Summary/Motivation:

The extra solve that was added to the block triangularization initialization was causing problems in WaterTap. This PR adds an option to skip it.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov
Copy link

codecov bot commented Nov 21, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.44%. Comparing base (3e87df6) to head (0032c12).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1711      +/-   ##
==========================================
- Coverage   77.45%   77.44%   -0.02%     
==========================================
  Files         395      395              
  Lines       64810    64812       +2     
  Branches    10908    10909       +1     
==========================================
- Hits        50200    50191       -9     
- Misses      12098    12107       +9     
- Partials     2512     2514       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

MarcusHolly
MarcusHolly approved these changes Nov 24, 2025
View reviewed changes
Copy link
Contributor

@MarcusHolly MarcusHolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Nov 24, 2025
@ksbeattie ksbeattie mentioned this pull request Nov 24, 2025
Merged
@dallan-keylogic dallan-keylogic enabled auto-merge (squash) November 24, 2025 17:33
@dallan-keylogic dallan-keylogic merged commit 2779114 into IDAES:main Nov 24, 2025
58 checks passed
@dallan-keylogic dallan-keylogic deleted the skip_final_solve branch November 24, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blnicho blnicho blnicho approved these changes

@MarcusHolly MarcusHolly MarcusHolly approved these changes

@agarciadiego agarciadiego Awaiting requested review from agarciadiego agarciadiego is a code owner

@adam-a-a adam-a-a Awaiting requested review from adam-a-a

@bpaul4 bpaul4 Awaiting requested review from bpaul4

Assignees

No one assigned

Labels

Priority:High High Priority Issue or PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dallan-keylogic @blnicho @MarcusHolly @ksbeattie