Skip to content

Convert setup.py to pyproject.toml #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ksbeattie merged 18 commits into from
Nov 26, 2025
Merged

Convert setup.py to pyproject.toml #1708

ksbeattie merged 18 commits into from
Nov 26, 2025

Conversation

@sufikaur
Copy link
Contributor

@sufikaur sufikaur commented Nov 21, 2025 •
edited
Loading

Fixes

Issue 1655

see older PR

Summary/Motivation:

  1. Since setup is a less modern approach it could be causing warnings/ issues like described in in issue 1476
  2. To maintain consistency with other idaesplus repos.

Changes proposed in this PR:

  • Delete setup.py
  • Transfer content described in setup.py to pyproject.toml
  • use importlib for conf.py

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Sufi Kaur added 3 commits November 20, 2025 17:24
co
9e15a0a 
nf docs use importlib instead of ver.py
remove ver import
e9aed99
create toml from setup.py
855f510
@codecov
Copy link

codecov bot commented Nov 21, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.46%. Comparing base (2779114) to head (40855de).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1708      +/-   ##
==========================================
+ Coverage   77.44%   77.46%   +0.01%     
==========================================
  Files         395      394       -1     
  Lines       64812    64746      -66     
  Branches    10909    10896      -13     
==========================================
- Hits        50196    50156      -40     
+ Misses      12101    12081      -20     
+ Partials     2515     2509       -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sufikaur sufikaur changed the title New toml Convert setup.py to pyproject.toml Nov 21, 2025
@sufikaur sufikaur mentioned this pull request Nov 25, 2025
Open
ksbeattie
ksbeattie approved these changes Nov 26, 2025
View reviewed changes
Copy link
Member

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@ksbeattie ksbeattie added Priority:High High Priority Issue or PR CI:run-integration triggers_workflow: Integration labels Nov 26, 2025
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Nov 26, 2025
@ksbeattie ksbeattie enabled auto-merge (squash) November 26, 2025 17:57
@ksbeattie ksbeattie disabled auto-merge November 26, 2025 18:23
@ksbeattie ksbeattie merged commit d4d10ea into IDAES:main Nov 26, 2025
65 of 113 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ksbeattie ksbeattie ksbeattie approved these changes

@lbianchi-lbl lbianchi-lbl lbianchi-lbl approved these changes

@dangunter dangunter Awaiting requested review from dangunter dangunter is a code owner

@bpaul4 bpaul4 Awaiting requested review from bpaul4 bpaul4 is a code owner

@agarciadiego agarciadiego Awaiting requested review from agarciadiego agarciadiego is a code owner

@dallan-keylogic dallan-keylogic Awaiting requested review from dallan-keylogic dallan-keylogic is a code owner

Assignees

No one assigned

Labels

Priority:High High Priority Issue or PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sufikaur @ksbeattie @lbianchi-lbl @idaes-build