Skip to content

Update extreme Jacobian methods to use a scaled Jacobian #1703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dallan-keylogic merged 6 commits into from
Nov 18, 2025
Merged

Update extreme Jacobian methods to use a scaled Jacobian #1703

dallan-keylogic merged 6 commits into from
Nov 18, 2025

Conversation

@dallan-keylogic
Copy link
Contributor

@dallan-keylogic dallan-keylogic commented Nov 14, 2025

Fixes

Resolves #1699

Summary/Motivation:

When updating the DiagnosticsToolbox to use a scaled Jacobian, I missed a few instances where an unscaled Jacobian was used. This PR fixes that.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@dallan-keylogic dallan-keylogic marked this pull request as ready for review November 17, 2025 15:38
@codecov
Copy link

codecov bot commented Nov 17, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.43%. Comparing base (36e6eb8) to head (dd20a4e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1703      +/-   ##
==========================================
- Coverage   77.46%   77.43%   -0.04%     
==========================================
  Files         395      395              
  Lines       64763    64785      +22     
  Branches    10897    10900       +3     
==========================================
- Hits        50171    50168       -3     
- Misses      12084    12104      +20     
- Partials     2508     2513       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dallan-keylogic dallan-keylogic added the CI:run-integration triggers_workflow: Integration label Nov 17, 2025
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Nov 17, 2025
MarcusHolly
MarcusHolly approved these changes Nov 17, 2025
View reviewed changes
Copy link
Contributor

@MarcusHolly MarcusHolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bpaul4
bpaul4 approved these changes Nov 18, 2025
View reviewed changes
Copy link
Contributor

@bpaul4 bpaul4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me.

@dallan-keylogic dallan-keylogic merged commit a0957e8 into IDAES:main Nov 18, 2025
105 of 112 checks passed
@dallan-keylogic dallan-keylogic deleted the extreme_jacobian_fix branch November 18, 2025 17:05
@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Nov 20, 2025
@dallan-keylogic dallan-keylogic mentioned this pull request Nov 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bpaul4 bpaul4 bpaul4 approved these changes

@MarcusHolly MarcusHolly MarcusHolly approved these changes

@agarciadiego agarciadiego Awaiting requested review from agarciadiego agarciadiego is a code owner

Assignees

No one assigned

Labels

Priority:High High Priority Issue or PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Extreme Jacobian rows and columns do not use scaled Jacobian

5 participants

@dallan-keylogic @bpaul4 @MarcusHolly @ksbeattie @idaes-build