Skip to content

Conversation

@mrmundt
Copy link
Contributor

@mrmundt mrmundt commented Sep 25, 2025

Fixes #1575

Summary/Motivation:

The v2 Pyomo solvers intrinsically support being passed loggers now rather than needing to wrap them in a utility to direct otherwise. This updates the IDAES documentation to reflect how solve logs can be captured in both the new and old world orders.

Preview: https://idaes-pse--1672.org.readthedocs.build/en/1672/reference_guides/logging.html#logging-solver-output

Changes proposed in this PR:

  • Update logging.rst to address Pyomo v2 solvers
  • Slight change of language to mildly shame anyone trying to use a v1 solver

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Copy link
Contributor

@dallan-keylogic dallan-keylogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.06%. Comparing base (00c61dc) to head (5e5cf38).
⚠️ Report is 41 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1672      +/-   ##
==========================================
- Coverage   77.06%   77.06%   -0.01%     
==========================================
  Files         395      395              
  Lines       62761    62761              
  Branches    10233    10233              
==========================================
- Hits        48369    48366       -3     
- Misses      11981    11985       +4     
+ Partials     2411     2410       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dallan-keylogic dallan-keylogic merged commit 2e7b873 into IDAES:main Sep 26, 2025
43 checks passed
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority:Normal Normal Priority Issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redirection of solver output is no longer needed

4 participants