Fix failing CoolProp test. #1650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1650 +/- ##
==========================================
- Coverage 77.01% 77.00% -0.01%
==========================================
Files 395 395
Lines 63555 63555
Branches 10365 10365
==========================================
- Hits 48944 48941 -3
- Misses 12171 12175 +4
+ Partials 2440 2439 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lbianchi-lbl
approved these changes
Aug 15, 2025
agarciadiego
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
CoolProp 7.0 introduced a discrepancy between physical parameter values returned by different methods. This is the result of the introduction of SuperAncillary functions: orthogonal polynomial approximations that help accelerate the nonlinear rootfinding inherent in Helmholtz EoS. They do, however, add a small amount of error in the critical properties returned. We can turn them off for the purposes of that test because only a few function calls are needed.
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: