Skip to content

Fix typo of _enthalpy_density_term #1638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ksbeattie merged 5 commits into from
Aug 28, 2025
Merged

Fix typo of _enthalpy_density_term #1638

ksbeattie merged 5 commits into from
Aug 28, 2025

Conversation

@aspitarl
Copy link
Contributor

@aspitarl aspitarl commented Jul 15, 2025 •
edited
Loading

Fixes

This fixes issue #1586

This fixes the typo in idaes-pse/idaes/models/properties/modular_properties/base/generic_property.py as described in issue #1586.

Note there was already a related pull request #1588, but that did not correctly fix the issue (did not have underscore on energy_density_term). I have successfully tested this fix through use of the generic property package.

Summary/Motivation:

This throws an error when calculating scaling factors with a generic property package

Changes proposed in this PR:

  • fixed _enthalpy_flow_term to _energy_density_term

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@aspitarl
fix typo of _enthalpy_density_term
8b703c6 
fixed to _energy_density_term

fixes IDAES#1586
@codecov
Copy link

codecov bot commented Jul 16, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.01%. Comparing base (0b57fe2) to head (86576a5).
⚠️ Report is 41 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1638   +/-   ##
=======================================
  Coverage   77.01%   77.01%           
=======================================
  Files         397      397           
  Lines       63580    63580           
  Branches    10367    10367           
=======================================
  Hits        48965    48965           
- Misses      12173    12174    +1     
+ Partials     2442     2441    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dallan-keylogic
dallan-keylogic approved these changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@dallan-keylogic dallan-keylogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Aug 7, 2025
@ksbeattie ksbeattie enabled auto-merge (squash) August 28, 2025 18:38
@ksbeattie ksbeattie merged commit 76b58d6 into IDAES:main Aug 28, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adam-a-a adam-a-a adam-a-a approved these changes

@agarciadiego agarciadiego agarciadiego approved these changes

@dallan-keylogic dallan-keylogic dallan-keylogic approved these changes

Assignees

@aspitarl aspitarl

Labels

Priority:Normal Normal Priority Issue or PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aspitarl @adam-a-a @agarciadiego @dallan-keylogic @ksbeattie