Skip to content

MEA Column Fix #1608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dallan-keylogic merged 18 commits into from
Apr 22, 2025
Merged

MEA Column Fix #1608

dallan-keylogic merged 18 commits into from
Apr 22, 2025

Conversation

@dallan-keylogic
Copy link
Contributor

@dallan-keylogic dallan-keylogic commented Apr 15, 2025

Summary/Motivation:

It's finally time to get the (mostly) fixed MEA column into IDAES.

Changes proposed in this PR:

  • MEA column tests pass again
  • Better initialization and scaling for electrolytes
  • Minor fixes in NTU heat exchanger and condenser model

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@dallan-keylogic dallan-keylogic mentioned this pull request Apr 15, 2025
Closed
@codecov
Copy link

codecov bot commented Apr 15, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 87.50000% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.06%. Comparing base (2fa1478) to head (dc5e0a4).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ement_factor_model_pseudo_second_order_explicit.py 85.36% 9 Missing and 3 partials ⚠️
idaes/models/unit_models/heat_exchanger_ntu.py 28.57% 5 Missing ⚠️
...aes/core/initialization/block_triangularization.py 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1608      +/-   ##
==========================================
+ Coverage   76.87%   77.06%   +0.18%     
==========================================
  Files         394      395       +1     
  Lines       63248    63512     +264     
  Branches    10361    10358       -3     
==========================================
+ Hits        48625    48943     +318     
+ Misses      12182    12130      -52     
+ Partials     2441     2439       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dallan-keylogic dallan-keylogic added the CI:run-integration triggers_workflow: Integration label Apr 17, 2025
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Apr 17, 2025
@dallan-keylogic dallan-keylogic merged commit 6a588c7 into IDAES:main Apr 22, 2025
39 checks passed
@dallan-keylogic dallan-keylogic deleted the mea-column-pr branch April 22, 2025 15:32
@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tannerpolley tannerpolley tannerpolley approved these changes

@anujad95 anujad95 anujad95 approved these changes

@aostace01 aostace01 Awaiting requested review from aostace01 aostace01 is a code owner

@agarciadiego agarciadiego Awaiting requested review from agarciadiego agarciadiego is a code owner

@bpaul4 bpaul4 Awaiting requested review from bpaul4 bpaul4 is a code owner

@lbianchi-lbl lbianchi-lbl Awaiting requested review from lbianchi-lbl

Assignees

No one assigned

Labels

Priority:High High Priority Issue or PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dallan-keylogic @tannerpolley @anujad95 @ksbeattie @idaes-build