Remove mappings from el9 to ubuntu #1599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blnicho
approved these changes
Mar 20, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1599 +/- ##
==========================================
- Coverage 76.85% 76.85% -0.01%
==========================================
Files 394 394
Lines 63241 63241
Branches 10359 10359
==========================================
- Hits 48604 48601 -3
- Misses 12188 12192 +4
+ Partials 2449 2448 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1456
Summary/Motivation:
The infrastructure is already nicely defined in
get-extensionsto yell loudly / stop if someone is on an unrecognized platform or a platform not seen in the distribution map. We discussed in #1456 that we should not make an arbitrary mapping and instead tell the user to use the--distrooption. This removes those arbitrary mappings, so now anyone who tries to runget-extensionson something we have not released will be given an error plus a help message.Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: