Skip to content

Bump minimum Pyomo version to 6.9.2 #1598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dallan-keylogic merged 7 commits into from
Apr 17, 2025
Merged

Bump minimum Pyomo version to 6.9.2 #1598

dallan-keylogic merged 7 commits into from
Apr 17, 2025

Conversation

@blnicho
Copy link
Member

@blnicho blnicho commented Mar 20, 2025

Summary/Motivation:

We merged the next set of changes to the new Pyomo solver interfaces. This PR bumps the IDAES tag of Pyomo to check for issues.

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@blnicho blnicho added the CI:run-integration triggers_workflow: Integration label Mar 20, 2025
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Mar 20, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2025 •
edited by codecov bot
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.87%. Comparing base (ea5190b) to head (66e1fb4).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1598      +/-   ##
==========================================
- Coverage   76.87%   76.87%   -0.01%     
==========================================
  Files         394      394              
  Lines       63248    63248              
  Branches    10361    10361              
==========================================
- Hits        48625    48622       -3     
- Misses      12182    12186       +4     
+ Partials     2441     2440       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Mar 20, 2025
@blnicho blnicho added the CI:run-integration triggers_workflow: Integration label Mar 24, 2025
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Mar 24, 2025
@blnicho blnicho added the CI:run-integration triggers_workflow: Integration label Apr 16, 2025
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Apr 16, 2025
@blnicho blnicho added the CI:run-integration triggers_workflow: Integration label Apr 16, 2025
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Apr 16, 2025
@jsiirola
Copy link
Contributor

jsiirola commented Apr 17, 2025

This PR now bumps the minimum version to the new Pyomo release.

(Because this PR tracks the import change in idaes/core/solvers/tests/test_solvers.py, merging it will break compatibility with pyomo 6.9.1. Talking with @dallan-keylogic, there is another PR waiting in the wings that will also rely on changes to compute_variable_from_constraint released in 6.9.2)

@jsiirola jsiirola changed the title Updating Pyomo tag to check for issues with solver V2 updates Bump minimum Pyomo version to 6.9.2 Apr 17, 2025
@dallan-keylogic dallan-keylogic merged commit 2fa1478 into IDAES:main Apr 17, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsiirola jsiirola jsiirola approved these changes

@mrmundt mrmundt mrmundt approved these changes

@lbianchi-lbl lbianchi-lbl Awaiting requested review from lbianchi-lbl

@ksbeattie ksbeattie Awaiting requested review from ksbeattie ksbeattie is a code owner

@agarciadiego agarciadiego Awaiting requested review from agarciadiego agarciadiego is a code owner

@dallan-keylogic dallan-keylogic Awaiting requested review from dallan-keylogic dallan-keylogic is a code owner

@bpaul4 bpaul4 Awaiting requested review from bpaul4 bpaul4 is a code owner

@avdudchenko avdudchenko Awaiting requested review from avdudchenko avdudchenko is a code owner

@rundxdi rundxdi Awaiting requested review from rundxdi rundxdi is a code owner

Assignees

No one assigned

Labels

Priority:High High Priority Issue or PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@blnicho @codecov-commenter @jsiirola @mrmundt @ksbeattie @idaes-build @dallan-keylogic