Skip to content

Conversation

@lbianchi-lbl
Copy link
Contributor

@lbianchi-lbl lbianchi-lbl commented Nov 27, 2024

Resolves #1540

Note

This is an alternative to #1541 since #1541 also tried to reproduce the failure in CI to try to develop a CI check that we could use to catch similar issues in the future. Since I haven't been able to do that yet, I've created this PR with the simplest possible set of changes that resolves #1540 so that it can be merged quickly for the Nov release

Changes proposed in this PR:

  • Shorten filename/prefix for test files in idaes/core/surrogate/tests/data/onnx_models from net_st_net_5000_STM_100_s_2000000_60_5_tanh_1e-06_4096_tr_15481_Calcite_ST to net_Calcite_ST

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@lbianchi-lbl lbianchi-lbl added the Priority:High High Priority Issue or PR label Nov 27, 2024
@lbianchi-lbl lbianchi-lbl self-assigned this Nov 27, 2024
@lbianchi-lbl lbianchi-lbl added the CI:run-integration triggers_workflow: Integration label Nov 27, 2024
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Nov 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.04%. Comparing base (4bf597e) to head (ca2c06b).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1545      +/-   ##
==========================================
- Coverage   77.05%   77.04%   -0.01%     
==========================================
  Files         384      384              
  Lines       62338    62338              
  Branches    10222    10222              
==========================================
- Hits        48034    48031       -3     
- Misses      11875    11879       +4     
+ Partials     2429     2428       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority:High High Priority Issue or PR

Projects

None yet

3 participants