Skip to content

Add a mapping for Pop!_OS (default for System76 laptops) to get-extensions #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lbianchi-lbl merged 14 commits into from
Nov 26, 2024
Merged

Add a mapping for Pop!_OS (default for System76 laptops) to get-extensions #1534

lbianchi-lbl merged 14 commits into from
Nov 26, 2024

Conversation

@dangunter
Copy link
Member

@dangunter dangunter commented Nov 14, 2024

Fixes

Summary/Motivation:

Pop!_OS is based on Ubuntu which is supported, but without this mapping idaes get-extensions fails.

Changes proposed in this PR:

  • Add a mapping from current version of Pop!_OS to associated version of Ubuntu

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@lbianchi-lbl lbianchi-lbl mentioned this pull request Nov 14, 2024
Open
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.04%. Comparing base (5841433) to head (0255d3d).
Report is 21 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1534      +/-   ##
==========================================
- Coverage   77.05%   77.04%   -0.01%     
==========================================
  Files         384      384              
  Lines       62338    62338              
  Branches    10222    10222              
==========================================
- Hits        48034    48031       -3     
- Misses      11875    11879       +4     
+ Partials     2429     2428       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Nov 21, 2024
ksbeattie
ksbeattie approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbianchi-lbl lbianchi-lbl merged commit 4bf597e into IDAES:main Nov 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ksbeattie ksbeattie ksbeattie approved these changes

@lbianchi-lbl lbianchi-lbl lbianchi-lbl approved these changes

@agarciadiego agarciadiego Awaiting requested review from agarciadiego

@dallan-keylogic dallan-keylogic Awaiting requested review from dallan-keylogic

Assignees

@dangunter dangunter

Labels

Priority:High High Priority Issue or PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dangunter @codecov-commenter @ksbeattie @lbianchi-lbl