Skip to content

Prune down unused dev dependencies #1533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lbianchi-lbl merged 3 commits into from
Nov 19, 2024
Merged

Prune down unused dev dependencies #1533

lbianchi-lbl merged 3 commits into from
Nov 19, 2024

Conversation

@lbianchi-lbl
Copy link
Contributor

@lbianchi-lbl lbianchi-lbl commented Nov 12, 2024

Resolves #1532

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@lbianchi-lbl lbianchi-lbl self-assigned this Nov 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.04%. Comparing base (c4336ba) to head (4c1a475).
Report is 22 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1533      +/-   ##
==========================================
- Coverage   77.05%   77.04%   -0.01%     
==========================================
  Files         384      384              
  Lines       62335    62335              
  Branches    10222    10222              
==========================================
- Hits        48031    48028       -3     
- Misses      11875    11879       +4     
+ Partials     2429     2428       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ksbeattie
ksbeattie approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Nov 14, 2024
@ksbeattie ksbeattie requested a review from dangunter November 14, 2024 19:23
@ksbeattie ksbeattie linked an issue Nov 14, 2024 that may be closed by this pull request
Issues with developer installation with "Failed to build jupyter_contrib_nbextensions" error #1529
Closed
@lbianchi-lbl lbianchi-lbl mentioned this pull request Nov 14, 2024
Closed
dangunter
dangunter approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@dangunter dangunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbianchi-lbl lbianchi-lbl merged commit a506ba5 into IDAES:main Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dangunter dangunter dangunter approved these changes

@ksbeattie ksbeattie ksbeattie approved these changes

Assignees

@lbianchi-lbl lbianchi-lbl

Labels

Priority:Normal Normal Priority Issue or PR

Projects

None yet

Milestone

No milestone

4 participants

@lbianchi-lbl @codecov-commenter @dangunter @ksbeattie