Skip to content

pinned ubuntu version to resolve failing gha jobs until support avail… #1506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lbianchi-lbl merged 1 commit into from
Oct 19, 2024
Merged

pinned ubuntu version to resolve failing gha jobs until support avail… #1506

lbianchi-lbl merged 1 commit into from
Oct 19, 2024

Conversation

@azaidi06
Copy link
Contributor

@azaidi06 azaidi06 commented Oct 18, 2024 •
edited
Loading

…ble in idaes extension

Fixes

issue #1499
#1499

Summary/Motivation:

Widespread test failures with Ubuntu 24.04, including ubuntu-latest GHA runner image -- this won't work without a pinned version of Ubuntu -- the longer term fix will take a while as it requires updated binaries of IDAES

Changes proposed in this PR:

Update the core.yml file to specify GHA is pinned to Ubuntu 22.04

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@azaidi06 azaidi06 requested a review from dangunter October 18, 2024 19:51
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.98%. Comparing base (2515fe8) to head (45b5408).
Report is 23 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1506      +/-   ##
==========================================
- Coverage   76.98%   76.98%   -0.01%     
==========================================
  Files         382      382              
  Lines       61911    61911              
  Branches    10126    10126              
==========================================
- Hits        47663    47660       -3     
- Misses      11848    11852       +4     
+ Partials     2400     2399       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lbianchi-lbl lbianchi-lbl enabled auto-merge (squash) October 18, 2024 21:55
@lbianchi-lbl lbianchi-lbl disabled auto-merge October 19, 2024 02:37
@lbianchi-lbl lbianchi-lbl merged commit 7369728 into IDAES:main Oct 19, 2024
@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blnicho blnicho blnicho approved these changes

@lbianchi-lbl lbianchi-lbl lbianchi-lbl approved these changes

@ksbeattie ksbeattie Awaiting requested review from ksbeattie ksbeattie is a code owner

@dangunter dangunter Awaiting requested review from dangunter

Assignees

No one assigned

Labels

Priority:High High Priority Issue or PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@azaidi06 @codecov-commenter @blnicho @lbianchi-lbl @ksbeattie