Skip to content

Address minor issues identified in 10/24 Code Audit #1504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andrewlee94 merged 8 commits into from
Oct 28, 2024
Merged

Address minor issues identified in 10/24 Code Audit #1504

andrewlee94 merged 8 commits into from
Oct 28, 2024

Conversation

@andrewlee94
Copy link
Contributor

@andrewlee94 andrewlee94 commented Oct 18, 2024

Fixes None

Summary/Motivation:

The developer team did a code audit in October and identified a number of issues that should be investigated and resolved if possible. This PR addresses those issues that are easily fixed.

Changes proposed in this PR:

  • Update CODEOWNERS file in light of staffing changes
  • Add condition to xfail marker on plate heat exchanger tests to only xfail on Windows system.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@andrewlee94 andrewlee94 self-assigned this Oct 18, 2024
@andrewlee94 andrewlee94 added Priority:Normal Normal Priority Issue or PR core Issues dealing with core modeling components testing Issues dealing with testing of code labels Oct 18, 2024
agarciadiego
agarciadiego approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@agarciadiego agarciadiego left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-requested review after Linux fail

@agarciadiego agarciadiego self-requested a review October 18, 2024 14:16
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.98%. Comparing base (d931060) to head (a5574f1).
Report is 20 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1504      +/-   ##
==========================================
- Coverage   76.99%   76.98%   -0.01%     
==========================================
  Files         382      382              
  Lines       61992    61992              
  Branches    10146    10146              
==========================================
- Hits        47730    47727       -3     
- Misses      11854    11858       +4     
+ Partials     2408     2407       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dallan-keylogic
dallan-keylogic reviewed Oct 24, 2024
View reviewed changes
andrewlee94
andrewlee94 commented Oct 24, 2024
View reviewed changes
agarciadiego
agarciadiego approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@agarciadiego agarciadiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

dallan-keylogic
dallan-keylogic approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@dallan-keylogic dallan-keylogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewlee94 andrewlee94 merged commit 1ed3f2c into IDAES:main Oct 28, 2024
@andrewlee94 andrewlee94 deleted the audit_10_24 branch October 28, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agarciadiego agarciadiego agarciadiego approved these changes

@dallan-keylogic dallan-keylogic dallan-keylogic approved these changes

@aostace01 aostace01 Awaiting requested review from aostace01 aostace01 is a code owner

@lbianchi-lbl lbianchi-lbl Awaiting requested review from lbianchi-lbl

@ksbeattie ksbeattie Awaiting requested review from ksbeattie ksbeattie is a code owner

Assignees

@andrewlee94 andrewlee94

Labels

core Issues dealing with core modeling components Priority:Normal Normal Priority Issue or PR testing Issues dealing with testing of code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewlee94 @codecov-commenter @agarciadiego @dallan-keylogic