Updating BTX param with units #1478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewlee94
approved these changes
Aug 28, 2024
Contributor
andrewlee94
left a comment
There was a problem hiding this comment.
This looks good to me, and should suppress a lot of annoying warnings.
MarcusHolly
approved these changes
Aug 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1478 +/- ##
==========================================
- Coverage 76.37% 76.36% -0.01%
==========================================
Files 393 393
Lines 65086 65086
Branches 14426 14426
==========================================
- Hits 49708 49705 -3
- Misses 12816 12820 +4
+ Partials 2562 2561 -1 ☔ View full report in Codecov by Sentry. |
bpaul4
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating BTX params with units to mutable. This is done to suppress the warning thrown by pyomo.
The changes take place in
idaes/models/properties/activity_coeff_models/BTX_activity_coeff_VLE.pyLegal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: