Skip to content

Remove SOFC Keras Surrogates And Tests #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lbianchi-lbl merged 3 commits into from
Aug 24, 2024
Merged

Remove SOFC Keras Surrogates And Tests #1475

lbianchi-lbl merged 3 commits into from
Aug 24, 2024

Conversation

@bpaul4
Copy link
Contributor

@bpaul4 bpaul4 commented Aug 22, 2024

Fixes

Closes #1431

Summary/Motivation:

Remove SOFC Keras surrogates that no longer work, as they as no longer used anywhere in the codebase.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@bpaul4 bpaul4 self-assigned this Aug 22, 2024
@bpaul4 bpaul4 requested a review from AlexNoring as a code owner August 22, 2024 22:33
@bpaul4 bpaul4 changed the title remove sofc keras surrogates and tests Remove SOFC Keras Surrogates And Tests Aug 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.36%. Comparing base (ff6471c) to head (8f724fb).
Report is 24 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1475   +/-   ##
=======================================
  Coverage   76.36%   76.36%           
=======================================
  Files         394      393    -1     
  Lines       65136    65085   -51     
  Branches    14429    14426    -3     
=======================================
- Hits        49743    49705   -38     
+ Misses      12831    12819   -12     
+ Partials     2562     2561    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

AlexNoring
AlexNoring approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@AlexNoring AlexNoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lbianchi-lbl lbianchi-lbl added surrogates Priority:High High Priority Issue or PR labels Aug 23, 2024
@lbianchi-lbl
Copy link
Contributor

lbianchi-lbl commented Aug 23, 2024

Thanks a lot @bpaul4. We're trying to get #1465 merged ASAP, and then we'll merge this in whenever possible after that.

@lbianchi-lbl lbianchi-lbl self-requested a review August 23, 2024 19:58
@lbianchi-lbl lbianchi-lbl merged commit 2b41748 into IDAES:main Aug 24, 2024
@bpaul4 bpaul4 deleted the remove-sofc-surrogates branch January 6, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexNoring AlexNoring AlexNoring approved these changes

@lbianchi-lbl lbianchi-lbl lbianchi-lbl approved these changes

Assignees

@bpaul4 bpaul4

Labels

Priority:High High Priority Issue or PR surrogates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sofc Keras Surrogates failing tests

4 participants

@bpaul4 @codecov-commenter @lbianchi-lbl @AlexNoring