Skip to content

Specify Codecov version to work around codecov/codecov-action#1487 #1441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ksbeattie merged 5 commits into from
Jul 18, 2024
Merged

Specify Codecov version to work around codecov/codecov-action#1487 #1441

ksbeattie merged 5 commits into from
Jul 18, 2024

Conversation

@lbianchi-lbl
Copy link
Contributor

@lbianchi-lbl lbianchi-lbl commented Jun 21, 2024

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@lbianchi-lbl lbianchi-lbl added the Priority:High High Priority Issue or PR label Jun 21, 2024
@lbianchi-lbl lbianchi-lbl self-assigned this Jun 21, 2024
andrewlee94
andrewlee94 approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@andrewlee94 andrewlee94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay for people maintaining backward compatibility!

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.35%. Comparing base (3c209b9) to head (3b785e9).
Report is 23 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1441      +/-   ##
==========================================
- Coverage   76.36%   76.35%   -0.01%     
==========================================
  Files         394      394              
  Lines       64953    64953              
  Branches    14404    14404              
==========================================
- Hits        49601    49598       -3     
- Misses      12793    12797       +4     
+ Partials     2559     2558       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewlee94 andrewlee94 enabled auto-merge (squash) June 21, 2024 17:18
@ksbeattie ksbeattie disabled auto-merge July 18, 2024 23:40
@ksbeattie ksbeattie merged commit 85bf669 into IDAES:main Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrmundt mrmundt mrmundt approved these changes

@bpaul4 bpaul4 bpaul4 approved these changes

@ksbeattie ksbeattie Awaiting requested review from ksbeattie ksbeattie is a code owner

+1 more reviewer

@andrewlee94 andrewlee94 andrewlee94 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lbianchi-lbl lbianchi-lbl

Labels

Priority:High High Priority Issue or PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lbianchi-lbl @codecov-commenter @andrewlee94 @mrmundt @bpaul4 @ksbeattie