bug fix for issue #1364: catch AttributeError in set_scaling_from_default #1400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewlee94
approved these changes
Apr 24, 2024
Contributor
|
@jasonmbray-p66 Thank you for taking the time to fix this for us. Contributions from users are always appreciated. |
radhakrishnatg
approved these changes
Apr 25, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1400 +/- ##
==========================================
- Coverage 77.70% 77.69% -0.01%
==========================================
Files 394 394
Lines 65033 65037 +4
Branches 14380 14380
==========================================
- Hits 50533 50531 -2
- Misses 11899 11906 +7
+ Partials 2601 2600 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
#1364 Incompatibility between set_scaling_from_default() and generic reaction parameter data
Summary/Motivation:
Currently set_scaling_from_default assumes all blocks have a
get_default_scaling()method, but this is not guaranteed.Changes proposed in this PR:
get_default_scaling()Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: