Skip to content

Tweaks to convergence tester #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ksbeattie merged 4 commits into from
Mar 21, 2024
Merged

Tweaks to convergence tester #1377

ksbeattie merged 4 commits into from
Mar 21, 2024

Conversation

@andrewlee94
Copy link
Contributor

@andrewlee94 andrewlee94 commented Mar 18, 2024

Fixes None

Summary/Motivation:

In adding some more robustness tests using the new convergence analysis tools, a bug was found as well as the need for a summary report of the convergence analysis.

Changes proposed in this PR:

  • Fixes bug in ParameterSweep
  • Adds a report method to IpoptConvergenceAnalysis

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@andrewlee94 andrewlee94 requested review from Robbybp and bpaul4 March 18, 2024 17:25
@andrewlee94 andrewlee94 self-assigned this Mar 18, 2024
@andrewlee94 andrewlee94 added bug Something isn't working enhancement New feature or request Priority:Normal Normal Priority Issue or PR testing Issues dealing with testing of code labels Mar 18, 2024
@andrewlee94 andrewlee94 mentioned this pull request Mar 18, 2024
Merged
dallan-keylogic
dallan-keylogic approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@dallan-keylogic dallan-keylogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@andrewlee94 andrewlee94 enabled auto-merge (squash) March 21, 2024 18:37
@ksbeattie ksbeattie disabled auto-merge March 21, 2024 18:41
@ksbeattie ksbeattie merged commit ecb07d8 into IDAES:main Mar 21, 2024
@andrewlee94 andrewlee94 deleted the convergence_testing_fixes branch March 21, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bpaul4 bpaul4 bpaul4 approved these changes

@dallan-keylogic dallan-keylogic dallan-keylogic approved these changes

@lbianchi-lbl lbianchi-lbl Awaiting requested review from lbianchi-lbl

@Robbybp Robbybp Awaiting requested review from Robbybp

Assignees

@andrewlee94 andrewlee94

Labels

bug Something isn't working enhancement New feature or request Priority:Normal Normal Priority Issue or PR testing Issues dealing with testing of code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewlee94 @bpaul4 @dallan-keylogic @ksbeattie