Skip to content

Conversation

@lbianchi-lbl
Copy link
Contributor

Fixes #1200

Changes proposed in this PR:

  • Remove --pyargs idaes from pytest.ini
  • Move markers definition from pytest.ini to idaes/conftest.py so that tests can be run without warnings without requiring pytest.ini, which is not available in non-editable installations without ad-hoc download

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 77.60%. Comparing base (38e67db) to head (9f52bcf).

Files Patch % Lines
idaes/conftest.py 63.63% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1362      +/-   ##
==========================================
- Coverage   77.60%   77.60%   -0.01%     
==========================================
  Files         391      391              
  Lines       64330    64333       +3     
  Branches    14244    14245       +1     
==========================================
  Hits        49923    49923              
- Misses      11831    11835       +4     
+ Partials     2576     2575       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lbianchi-lbl lbianchi-lbl added the CI:run-integration triggers_workflow: Integration label Mar 1, 2024
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Mar 1, 2024
@lbianchi-lbl lbianchi-lbl marked this pull request as ready for review March 1, 2024 20:55
@lbianchi-lbl lbianchi-lbl requested a review from ksbeattie as a code owner March 1, 2024 20:55
@lbianchi-lbl lbianchi-lbl self-assigned this Mar 1, 2024
@lbianchi-lbl lbianchi-lbl added the Priority:Normal Normal Priority Issue or PR label Mar 1, 2024
Copy link
Contributor

@andrewlee94 andrewlee94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, but I am no expert on configuring pytest.

Copy link
Member

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbianchi-lbl lbianchi-lbl enabled auto-merge (squash) March 13, 2024 14:10
@ksbeattie ksbeattie disabled auto-merge March 14, 2024 18:46
@ksbeattie ksbeattie merged commit c09433b into IDAES:main Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority:Normal Normal Priority Issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to run pytest on a single test file

4 participants