Skip to content

Bubble/dew methods broken for Henry's law #718

@dallan-keylogic

Description

@dallan-keylogic

Right now, one cannot call bubble/dew methods for a phase when Henry's law components are present, because the ideal EoS still uses the old Henry's law syntax to call them. Unfortunately, the solution is harder than just updating the syntax, because some Henry forms use a concentration basis instead of a mole fraction basis for the Henry's law expression. The (log_)henry_pressure does some logic to use the right form of concentration, so that logic needs to be repeated at bubble/dew concentrations. Furthermore, if a concentration basis is used, then a V_mol_dew variable needs to be created.

While we're fixing this, it wouldn't hurt to rename (log_)henry_pressure to (log_)henry_fugacity.

Metadata

Metadata

Labels

Priority:LowLow Priority Issue or PR

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions