Skip to content

Conversation

@shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Apr 14, 2025

  • Rule bug: input_label_exists, aria_widget_labelled, aria_accessiblename_exists

This PR is related to the following issue(s):

Testing reference:

  • test case: test/v2/checker/accessibility/rules/aria_accessiblename_exists_ruleunit/elements-no-label.html
  • Switch to "Rules"
  • Before the fixes: there were 8 violations: "Interactive component must have a programmatically associated name", with one for "radiogroup" and one for "alertdialog".
    and 5 recommendations: "Elements with certain roles should have accessible names", with one for "form" and one for "table".
  • After the fixes: 6 violations, no violation for "radiogroup" or "alertdialog".
    and 3 recommendations, no recommendations for "form" or "table".

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

Assets to aide review attached

  • Links to design artifacts
  • Links to video walkthrough of user experience
  • Other

Definition of Done

  • Peer review complete
  • Secondary review complete
  • Staging deployment verified

@shunguoy shunguoy marked this pull request as ready for review April 15, 2025 14:05
@tombrunet tombrunet merged commit fd7a6e3 into main-4.x Apr 24, 2025
16 checks passed
@tombrunet tombrunet deleted the dev-1920-v4 branch April 24, 2025 14:18
@philljenkins philljenkins changed the title fixrule(input_label_exists, aria_widget_labelled, aria_accessiblename_exists): Update accessible name requirement for certain roles V4 fixrule(input_label_exists, aria_widget_labelled, aria_accessiblename_exists): Update accessible name requirement for certain roles V4 May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix issues related to the tabbable widget with role 'none' Handle case where nameRequired is true, but not a widget

5 participants