Feat: Added Data encoder and decoder#28
Merged
Andrew-Lees11 merged 8 commits intomasterfrom Aug 24, 2018
Merged
Conversation
2 tasks
ianpartridge
approved these changes
Aug 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an encode from data and decode from data to our QueryEncoder and QueryDecoder. This is required so the coders fit our BodyEncoder/Decoder protocol for our custom decoders branch.
Since this encourages users to use the same encoder/decoder for multiple uses we also made them thread safe.
The file String+Extensions is requires and so has been added to extensions. We may want to make TypeAliases in Kitura to avoid code duplication.
Cyclic tests for Data have been added where a codable type is encoded and then decoded back to its original type.