Conversation
this fixes an issue with NLU when trying to send a file through a put request. Otherwise, it would change the put request to a post automatically.
mediumTaj
reviewed
Jun 10, 2021
| if (req.HttpMethod == UnityWebRequest.kHttpVerbPUT) | ||
| { | ||
| unityWebRequest.method = "PUT"; | ||
| } |
Member
There was a problem hiding this comment.
This seems a bit inconsistent btw post and put
does this work?
if (req.HttpMethod == UnityWebRequest.kHttpVerbPOST)
{
unityWebRequest = UnityWebRequest.Post(url, form);
}
if (req.HttpMethod == UnityWebRequest.kHttpVerbPUT)
{
unityWebRequest = UnityWebRequest.Put(url, form);
}
Contributor
Author
There was a problem hiding this comment.
@mediumTaj Put doesn't allow formdata in the second parameter
mediumTaj
approved these changes
Jun 10, 2021
jeff-arn
approved these changes
Jun 10, 2021
Member
|
🎉 This PR is included in version 1.2.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes an issue with NLU when trying to send a file through a put request. Otherwise, it would
change the put request to a post automatically.