Skip to content

fix(ATracker): add new regions in-mum for Atracker service#444

Closed
TharunKM1 wants to merge 8 commits into
IBM:mainfrom
TharunKM1:regen-atracker-04272026
Closed

fix(ATracker): add new regions in-mum for Atracker service#444
TharunKM1 wants to merge 8 commits into
IBM:mainfrom
TharunKM1:regen-atracker-04272026

Conversation

@TharunKM1

Copy link
Copy Markdown
Contributor

PR summary

Added new regions Mumbai(in-mum) to ATracker service

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@CLAassistant

CLAassistant commented Apr 28, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 4 committers have signed the CLA.

✅ aman-verma-ibm
✅ TharunKM1
❌ K M Tharun
❌ semantic-release-bot


K M Tharun seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@TharunKM1

TharunKM1 commented Apr 28, 2026

Copy link
Copy Markdown
Contributor Author

Integration tests are successful
image

Unit test
image

@TharunKM1

Copy link
Copy Markdown
Contributor Author

@pyrooka — or anyone available — could you please review these changes.

@pyrooka pyrooka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides my other comment please:

  • Make sure your commits are signed-off (details here)
  • Use a valid user that is assigned with you GitHub account. Seems the user who created the first commit does not exists here, therefore it cannot accept the CLA.
  • Please also attach a screenshot of a clean examples test run.

Comment thread atrackerv2/atracker_v2.go Outdated
@TharunKM1 TharunKM1 force-pushed the regen-atracker-04272026 branch from 2e9c71f to d7eacc7 Compare April 29, 2026 14:49
@TharunKM1

Copy link
Copy Markdown
Contributor Author

@pyrooka please find the example test result
image

@pyrooka

pyrooka commented Apr 29, 2026

Copy link
Copy Markdown
Member

As it was discussed internally, I close this PR in favor of #445

@pyrooka pyrooka closed this Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants