Skip to content

fix(Logs Router): add changes for migration apis#435

Merged
pyrooka merged 6 commits into
IBM:mainfrom
aman-verma-ibm:migration-changes-for-log-router-v3-sdk
Apr 13, 2026
Merged

fix(Logs Router): add changes for migration apis#435
pyrooka merged 6 commits into
IBM:mainfrom
aman-verma-ibm:migration-changes-for-log-router-v3-sdk

Conversation

@aman-verma-ibm

@aman-verma-ibm aman-verma-ibm commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Running Test Suite-

image

@aman-verma-ibm aman-verma-ibm force-pushed the migration-changes-for-log-router-v3-sdk branch from 0c6b3c9 to 7127d71 Compare April 7, 2026 10:57
@CLAassistant

CLAassistant commented Apr 7, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@aman-verma-ibm aman-verma-ibm force-pushed the migration-changes-for-log-router-v3-sdk branch from 1039dbc to e6cb302 Compare April 8, 2026 06:27
@aman-verma-ibm aman-verma-ibm marked this pull request as ready for review April 8, 2026 07:01

@dinesh-venkatraman dinesh-venkatraman left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the DCO requirement and other pipeline status

@pyrooka pyrooka self-requested a review April 9, 2026 09:27
@pyrooka pyrooka self-assigned this Apr 9, 2026

@pyrooka pyrooka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I'd like to ask two things before proceeding with the review:

  1. Provide evidence of a clean test run for both the integration and examples tests
  2. Please format the code using the go fmt command.

@aman-verma-ibm aman-verma-ibm force-pushed the migration-changes-for-log-router-v3-sdk branch from 98dba8b to b930dc3 Compare April 10, 2026 13:07
Signed-off-by: aman verma <aman.verma@ibm.com>
@aman-verma-ibm aman-verma-ibm force-pushed the migration-changes-for-log-router-v3-sdk branch from b930dc3 to b213a22 Compare April 10, 2026 13:08
Signed-off-by: aman verma <aman.verma@ibm.com>
Signed-off-by: aman verma <aman.verma@ibm.com>
Signed-off-by: aman verma <aman.verma@ibm.com>
Signed-off-by: aman verma <aman.verma@ibm.com>
Signed-off-by: aman verma <aman.verma@ibm.com>
@aman-verma-ibm aman-verma-ibm force-pushed the migration-changes-for-log-router-v3-sdk branch from b213a22 to a3994d0 Compare April 10, 2026 13:17
@aman-verma-ibm

Copy link
Copy Markdown
Contributor Author

Hi! I'd like to ask two things before proceeding with the review:

  1. Provide evidence of a clean test run for both the integration and examples tests
  2. Please format the code using the go fmt command. - Pushed the changes
image

Example test
image

Integration

image

@pyrooka pyrooka changed the title Added changes for migration apis for logs router v3 sdk fix(Logs Router): add changes for migration apis Apr 13, 2026

@pyrooka pyrooka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pyrooka pyrooka merged commit 67a04dd into IBM:main Apr 13, 2026
7 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Apr 13, 2026
## [0.97.2](v0.97.1...v0.97.2) (2026-04-13)

### Bug Fixes

* **Logs Router:** add changes for migration apis ([#435](#435)) ([67a04dd](67a04dd))
@ibm-devx-sdk

Copy link
Copy Markdown

🎉 This PR is included in version 0.97.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants