Skip to content

fix(plugins): update external plugin Containerfiles and test configs#3211

Open
crivetimihai wants to merge 19 commits intomainfrom
issue-3046
Open

fix(plugins): update external plugin Containerfiles and test configs#3211
crivetimihai wants to merge 19 commits intomainfrom
issue-3046

Conversation

@crivetimihai
Copy link
Copy Markdown
Member

Note: This PR was re-created from #3113 due to repository maintenance. Your code and branch are intact. @tedhabeck please verify everything looks good.

🔗 Related Issue

Closes #3046


📝 Summary

Problem(s):

  • External plugin Containerfiles missing or using stale mcp-contextforge-gateway install
  • Package conflict between pytest-env and pytest-dotenv
  • llmguard build error during execution of cache_tokenizers.py.
  • coverage tests not displayed when run in container
  • when running the llmguardplugintesting container, the default redis host should be, 'redis'
  • llmguardplugin Containerfile erroneously copying tests folder contents to the root folder in llmguardplugin-testing

Fixes:

  • Containerfiles updated to install mcp-contextforge-gateway branch main per bug report.
  • pytest-dotenv dependencies removed.
  • Added ENV TORCHINDUCTOR_CACHE_DIR=/tmp/torchinductor to llmguard's containerfile per workaround for issue: KeyError in default_cache_dir() when user account doesn't exist pytorch/pytorch#140765
  • Updated pytest.ini to update --cov parameter.
  • Updated the redis_host default value in test_llmguardplugin.py
  • llmguardplugin containerfile updated to remove tests folder copy to container root.
  • llmguardplugin .coveragerc updated to properly select test targets, and .dockerignore updated so that .coveragerc copies into container for testing.

🏷️ Type of Change

  • Bug fix
  • Feature / Enhancement
  • Documentation
  • Refactor
  • Chore (deps, CI, tooling)
  • Other (describe below)

🧪 Verification

Check Command Status
Lint suite make lint
Unit tests make test
Coverage ≥ 80% make coverage

✅ Checklist

  • Code formatted (make black isort pre-commit)
  • Tests added/updated for changes
  • Documentation updated (if applicable)
  • No secrets or credentials committed

📓 Notes (optional)

Screenshots, design decisions, or additional context.

…oject.toml, add as explicit install from branch main in Containerfile, update pytest.ini `--cov=.`, remove pytest-dotenv (conflict with pytest-env).

Signed-off-by: habeck <habeck@us.ibm.com>
Signed-off-by: habeck <habeck@us.ibm.com>
Signed-off-by: habeck <habeck@us.ibm.com>
Signed-off-by: habeck <habeck@us.ibm.com>
Signed-off-by: habeck <habeck@us.ibm.com>
Signed-off-by: habeck <habeck@us.ibm.com>
Signed-off-by: habeck <habeck@us.ibm.com>
…g in test container complete properly.

Signed-off-by: habeck <habeck@us.ibm.com>
Signed-off-by: habeck <habeck@us.ibm.com>
Signed-off-by: habeck <habeck@us.ibm.com>
…properly ignored

Signed-off-by: habeck <habeck@us.ibm.com>
Signed-off-by: habeck <habeck@us.ibm.com>
Signed-off-by: habeck <habeck@us.ibm.com>
Signed-off-by: habeck <habeck@us.ibm.com>
Signed-off-by: habeck <habeck@us.ibm.com>
Signed-off-by: habeck <habeck@us.ibm.com>
@crivetimihai crivetimihai added this to the Release 1.0.0-GA milestone Feb 24, 2026
@crivetimihai crivetimihai added bug Something isn't working plugins SHOULD P2: Important but not vital; high-value items that are not crucial for the immediate release labels Feb 24, 2026
@tedhabeck
Copy link
Copy Markdown
Collaborator

Note: This PR was re-created from #3113 due to repository maintenance. Your code and branch are intact. @tedhabeck please verify everything looks good.

LGTM 👍

Copy link
Copy Markdown
Collaborator

@tedhabeck tedhabeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working plugins SHOULD P2: Important but not vital; high-value items that are not crucial for the immediate release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][PLUGINS]: External plugin Containerfiles missing or using stale mcp-contextforge-gateway install

2 participants