fix(ui): replace tojson with single-quoted literals in Fetch Tools onclick#3179
fix(ui): replace tojson with single-quoted literals in Fetch Tools onclick#3179crivetimihai wants to merge 1 commit intomainfrom
Conversation
…k handler Signed-off-by: Oriol Morros Vilaseca <OM368@student.aru.ac.uk>
|
Hi @crivetimihai thanks for reopening this! I've verified the code, everything looks good, intact and matching my original changes. Ready for review whenever you get the chance. Thanks! |
|
@omorros - can you please resolve conflicts? |
|
Hi @crivetimihai @marekdano I've rebased the fix onto the latest main and it's ready to go, but since the PR branch lives on the IBM repo I don't have push access to update it directly. Would it be okay if I open a new PR from my fork instead? Happy to link it to #3082 and reference this one. Let me know! |
@omorros - If creating a new PR helps to solve the issue, please create a new PR and reference this one there. |
|
Closing this PR. A new PR #3616 has been created to cover the fix |
🔗 Related Issue
Closes #3082
📝 Summary
The "Fetch Tools" button in
gateways_partial.htmlwas broken because|tojsonoutputs double-quoted JSON strings inside adouble-quoted
onclickattribute, corrupting HTML parsing. Replaced with single-quoted JS literals to match the workingpattern used everywhere else in the templates.
🏷️ Type of Change
🧪 Verification
make lintmake testmake coverage✅ Checklist
make black isort pre-commit)📓 Notes (optional)
Single line change in
gateways_partial.html:41. The same button works correctly inadmin.html(initial page load) whichalready uses single quotes — this fix aligns the HTMX partial to match.