Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix-2360: prevent asyncio CPU spin loop after SSE client disconnect

Root cause: Fire-and-forget asyncio.create_task() patterns left orphaned
tasks that caused anyio _deliver_cancellation to spin at 100% CPU per worker.

Changes:
- Add _respond_tasks dict to track respond tasks by session_id
- Cancel respond tasks explicitly before session cleanup in remove_session()
- Cancel all respond tasks during shutdown()
- Pass disconnect callback to SSE transport for defensive cleanup
- Convert database backend from fire-and-forget to structured concurrency

The fix ensures all asyncio tasks are properly tracked, cancelled on disconnect,
and awaited to completion, preventing orphaned tasks from spinning the event loop.

Closes IBM#2360

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix-2360: additional fixes for CPU spin loop after SSE disconnect

Follow-up fixes based on testing and review:

1. Cancellation timeout escalation (Finding 1):
   - _cancel_respond_task() now escalates on timeout by calling transport.disconnect()
   - Retries cancellation after escalation
   - Always removes task from tracking to prevent buildup

2. Redis respond loop exit path (Finding 2):
   - Changed from infinite pubsub.listen() to timeout-based get_message() polling
   - Added session existence check - loop exits if session removed
   - Allows loop to exit even without cancellation

3. Generator finally block cleanup (Finding 3):
   - Added on_disconnect_callback() in event_generator() finally block
   - Covers: CancelledError, GeneratorExit, exceptions, and normal completion
   - Idempotent - safe if callback already ran from on_client_close

4. Added load-test-spin-detector make target:
   - Spike/drop pattern to stress test session cleanup
   - Docker stats monitoring at each phase
   - Color-coded output with pass/fail indicators
   - Log file output to /tmp

Closes IBM#2360

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix-2360: fix race condition in sse_endpoint and add stuck task tracking

Finding 1 (HIGH): Fixed race condition in sse_endpoint where respond task
was created AFTER create_sse_response(). If client disconnected during
response setup, the disconnect callback ran before the task existed,
leaving it orphaned. Now matches utility_sse_endpoint ordering:
1. Compute user_with_token
2. Create and register respond task
3. Call create_sse_response()

Finding 2 (MEDIUM): Added _stuck_tasks dict to track tasks that couldn't
be cancelled after escalation. Previously these were dropped from tracking
entirely, losing visibility. Now they're moved to _stuck_tasks for
monitoring and final cleanup during shutdown().

Updated tests to verify escalation behavior.

Closes IBM#2360

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix-2360: add SSE failure cleanup, stuck task reaper, and full load test

Finding 1 (HIGH): Fixed orphaned respond task when create_sse_response()
fails. Added try/except around create_sse_response() in both sse_endpoint
and utility_sse_endpoint - on failure, calls remove_session() to clean up
the task and session before re-raising.

Finding 2 (MEDIUM): Added stuck task reaper that runs every 30 seconds to:
- Remove completed tasks from _stuck_tasks
- Retry cancellation for still-stuck tasks
- Prevent memory leaks from tasks that eventually complete

Finding 3 (LOW): Added test for escalation path with fake transport to
verify transport.disconnect() is called during escalation. Also added
tests for the stuck task reaper lifecycle.

Also updated load-test-spin-detector to be a full-featured test matching
load-test-ui with JWT auth, all user classes, entity ID fetching, and
the same 4000-user baseline.

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix-2360: improve load-test-spin-detector output and reduce cycle sizes

- Reduce logging level to WARNING to suppress noisy worker messages
- Only run entity fetching and cleanup on master/standalone nodes
- Reduce cycle sizes from 4000 to 1000 peak users for faster iteration
- Update banner to reflect new cycle pattern (500 -> 750 -> 1000)
- Remove verbose JWT token generation log

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix-2360: address remaining CPU spin loop findings

Finding 1 (HIGH): Add explicit asyncio.CancelledError handling in SSE
endpoints. In Python 3.8+, CancelledError inherits from BaseException,
not Exception, so the previous except block wouldn't catch it. Now
cleanup runs even when requests are cancelled during SSE handshake.

Finding 2 (MEDIUM): Add sleep(0.1) when Redis get_message returns None
to prevent tight loop. The loop now has guaranteed minimum sleep even
when Redis returns immediately in certain states.

Finding 3 (MEDIUM): Add _closing_sessions set to allow respond loops
to exit early. remove_session() now marks the session as closing BEFORE
attempting task cancellation, so the respond loop (Redis and DB backends)
can exit immediately without waiting for the full cancellation timeout.

Finding 4 (LOW): Already addressed in previous commit with test
test_cancel_respond_task_escalation_calls_transport_disconnect.

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix-2360: make load-test-spin-detector run unlimited cycles

- Cycles now repeat indefinitely instead of stopping after 5
- Fixed log file path to /tmp/spin_detector.log for easy monitoring
- Added periodic summary every 5 cycles showing PASS/WARN/FAIL counts
- Cycle numbering now shows total count and pattern letter (e.g., "CYCLE 6 (A)")
- Banner shows monitoring command: tail -f /tmp/spin_detector.log

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix-2360: add asyncio.CancelledError to SSE endpoint Raises docs

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* Linting

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix-2360: remove redundant asyncio.CancelledError handlers

CancelledError inherits from BaseException in Python 3.8+, so it won't
be caught by 'except Exception' handlers. The explicit handlers were
unnecessary and triggered pylint W0706 (try-except-raise).

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix-2360: restore asyncio.CancelledError in Raises docs for inner handlers

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix-2360: add sleep on non-message Redis pubsub types to prevent spin

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix(pubsub): replace blocking listen() with timeout-based get_message()

The blocking `async for message in pubsub.listen()` pattern doesn't
respond to asyncio cancellation properly. When anyio's cancel scope
tries to cancel tasks using this pattern, the tasks don't respond
because the async iterator is blocked waiting for Redis messages.

This causes anyio's `_deliver_cancellation` to continuously reschedule
itself with `call_soon()`, creating a CPU spin loop that consumes
100% CPU per affected worker.

Changed to timeout-based polling pattern:
- Use `get_message(timeout=1.0)` with `asyncio.wait_for()`
- Loop allows cancellation check every ~1 second
- Added sleep on None/non-message responses to prevent edge case spins

Files fixed:
- mcpgateway/services/cancellation_service.py
- mcpgateway/services/event_service.py

Closes IBM#2360 (partial - additional spin sources may exist)

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix(cleanup): add timeouts to __aexit__ calls to prevent CPU spin loops

The MCP session/transport __aexit__ methods can block indefinitely when
internal tasks don't respond to cancellation. This causes anyio's
_deliver_cancellation to spin in a tight loop, consuming ~800% CPU.

Root cause: When calling session.__aexit__() or transport.__aexit__(),
they attempt to cancel internal tasks (like post_writer waiting on
memory streams). If these tasks don't respond to CancelledError, anyio's
cancel scope keeps calling call_soon() to reschedule _deliver_cancellation,
creating a CPU spin loop.

Changes:
- Add SESSION_CLEANUP_TIMEOUT constant (5 seconds) to mcp_session_pool.py
- Wrap all __aexit__ calls in asyncio.wait_for() with timeout
- Add timeout to pubsub cleanup in session_registry.py and registry_cache.py
- Add timeout to streamable HTTP context cleanup in translate.py

This is a continuation of the fix for issue IBM#2360.

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* feat(config): make session cleanup timeout configurable

Add MCP_SESSION_POOL_CLEANUP_TIMEOUT setting (default: 5.0 seconds) to
control how long cleanup operations wait for session/transport __aexit__
calls to complete.

Clarification: This timeout does NOT affect tool execution time (which
uses TOOL_TIMEOUT). It only affects cleanup of idle/released sessions
to prevent CPU spin loops when internal tasks don't respond to cancel.

Changes:
- Add mcp_session_pool_cleanup_timeout to config.py
- Add MCP_SESSION_POOL_CLEANUP_TIMEOUT to .env.example with docs
- Add to charts/mcp-stack/values.yaml
- Update mcp_session_pool.py to use _get_cleanup_timeout() helper
- Update session_registry.py and registry_cache.py to use config
- Update translate.py to use config with fallback

When to adjust:
- Increase if you see frequent "cleanup timed out" warnings in logs
- Decrease for faster shutdown (at risk of resource leaks)

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix(sse): add deadline to cancel scope to prevent CPU spin loop

Fixes CPU spin loop (anyio#695) where _deliver_cancellation spins at
100% CPU when SSE task group tasks don't respond to cancellation.

Root cause: When an SSE connection ends, sse_starlette's task group
tries to cancel all tasks. If a task (like _listen_for_disconnect
waiting on receive()) doesn't respond to cancellation, anyio's
_deliver_cancellation keeps rescheduling itself in a tight loop.

Fix: Override EventSourceResponse.__call__ to set a deadline on the
cancel scope when cancellation starts. This ensures that if tasks
don't respond within SSE_TASK_GROUP_CLEANUP_TIMEOUT (5 seconds),
the scope times out instead of spinning indefinitely.

References:
- agronholm/anyio#695
- anthropics/claude-agent-sdk-python#378

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix(translate): use patched EventSourceResponse to prevent CPU spin

translate.py was importing EventSourceResponse directly from sse_starlette,
bypassing the patched version in sse_transport.py that prevents the anyio
_deliver_cancellation CPU spin loop (anyio#695).

This change ensures all SSE connections in the translate module (stdio-to-SSE
bridge) also benefit from the cancel scope deadline fix.

Relates to: IBM#2360

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix(cleanup): reduce cleanup timeouts from 5s to 0.5s

With many concurrent connections (691 TCP sockets observed), each cancelled
SSE task group spinning for up to 5 seconds caused sustained high CPU usage.
Reducing the timeout to 0.5s minimizes CPU waste during spin loops while
still allowing normal cleanup to complete.

The cleanup timeout only affects cleanup of cancelled/released connections,
not normal operation or tool execution time.

Changes:
- SSE_TASK_GROUP_CLEANUP_TIMEOUT: 5.0 -> 0.5 seconds
- mcp_session_pool_cleanup_timeout: 5.0 -> 0.5 seconds
- Updated .env.example and charts/mcp-stack/values.yaml

Relates to: IBM#2360

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* refactor(cleanup): make SSE cleanup timeout configurable with safe defaults

- Add SSE_TASK_GROUP_CLEANUP_TIMEOUT setting (default: 5.0s)
- Make sse_transport.py read timeout from config via lazy loader
- Keep MCP_SESSION_POOL_CLEANUP_TIMEOUT at 5.0s default
- Override both to 0.5s in docker-compose.yml for testing

The 5.0s default is safe for production. The 0.5s override in
docker-compose.yml allows testing aggressive cleanup to verify
it doesn't affect normal operation.

Relates to: IBM#2360

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix(gunicorn): reduce max_requests to recycle stuck workers

The MCP SDK's internal anyio task groups don't respond to cancellation
properly, causing CPU spin loops in _deliver_cancellation. This spin
happens inside the MCP SDK (streamablehttp_client, sse_client) which
we cannot patch.

Reduce GUNICORN_MAX_REQUESTS from 10M to 5K to ensure workers are
recycled frequently, cleaning up any accumulated stuck task groups.

Root cause chain observed:
1. PostgreSQL idle transaction timeout
2. Gateway state change failures
3. SSE connections terminated
4. MCP SDK task groups spin (anyio#695)

This is a workaround until the MCP SDK properly handles cancellation.

Relates to: IBM#2360

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* Linting

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix(anyio): monkey-patch _deliver_cancellation to prevent CPU spin

Root cause: anyio's _deliver_cancellation has no iteration limit.
When tasks don't respond to CancelledError, it schedules call_soon()
callbacks indefinitely, causing 100% CPU spin (anyio#695).

Solution:
- Monkey-patch CancelScope._deliver_cancellation to track iterations
- Give up after 100 iterations and log warning
- Clear _cancel_handle to stop further call_soon() callbacks

Also switched from asyncio.wait_for() to anyio.move_on_after() for
MCP session cleanup, which better propagates cancellation through
anyio's cancel scope system.

Trade-off: If cancellation gives up after 100 iterations, some tasks
may not be properly cancelled. However, GUNICORN_MAX_REQUESTS=5000
worker recycling will eventually clean up orphaned tasks.

Closes IBM#2360

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* refactor(anyio): make _deliver_cancellation patch optional and disabled by default

The anyio monkey-patch is now feature-flagged and disabled by default:
- ANYIO_CANCEL_DELIVERY_PATCH_ENABLED=false (default)
- ANYIO_CANCEL_DELIVERY_MAX_ITERATIONS=100

This allows testing performance with and without the patch, and easy
rollback if upstream anyio/MCP SDK fixes the issue.

Added:
- Config settings for enabling/disabling the patch
- apply_anyio_cancel_delivery_patch() function for explicit control
- remove_anyio_cancel_delivery_patch() to restore original behavior
- Documentation in .env.example and docker-compose.yml

To enable: set ANYIO_CANCEL_DELIVERY_PATCH_ENABLED=true

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* docs: add comprehensive CPU spin loop mitigation documentation (IBM#2360)

Add multi-layered documentation for CPU spin loop mitigation settings
across all configuration files. This ensures operators understand and
can tune the workarounds for anyio#695.

Changes:
- .env.example: Add Layer 1/2/3 headers with cross-references to docs
  and issue IBM#2360, document all 6 mitigation variables
- README.md: Expand "CPU Spin Loop Mitigation" section with all 3 layers,
  configuration tables, and tuning tips
- docker-compose.yml: Consolidate all mitigation variables into one
  section with SSE protection (Layer 1), cleanup timeouts (Layer 2),
  and experimental anyio patch (Layer 3)
- charts/mcp-stack/values.yaml: Add comprehensive mitigation section
  with layer documentation and cross-references
- docs/docs/operations/cpu-spin-loop-mitigation.md: NEW - Full guide
  with root cause analysis, 4-layer defense diagram, configuration
  tables, diagnostic commands, and tuning recommendations
- docs/docs/.pages: Add Operations section to navigation
- docs/docs/operations/.pages: Add nav for operations docs

Mitigation variables documented:
- Layer 1: SSE_SEND_TIMEOUT, SSE_RAPID_YIELD_WINDOW_MS, SSE_RAPID_YIELD_MAX
- Layer 2: MCP_SESSION_POOL_CLEANUP_TIMEOUT, SSE_TASK_GROUP_CLEANUP_TIMEOUT
- Layer 3: ANYIO_CANCEL_DELIVERY_PATCH_ENABLED, ANYIO_CANCEL_DELIVERY_MAX_ITERATIONS

Related: IBM#2360, anyio#695, claude-agent-sdk#378
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* feat(loadtest): aggressive spin detector with configurable timings

Update spin detector load test for faster issue reproduction:
- Increase user counts: 4000 → 4000 → 10000 pattern
- Fast spawn rate: 1000 users/s
- Shorter wait times: 0.01-0.1s between requests
- Reduced connection timeouts: 5s (fail fast)

Related: IBM#2360
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* compose mitigation

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* load test

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* Defaults

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* Defaults

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* docs: add docstring to cancel_on_finish for interrogate coverage

Add docstring to nested cancel_on_finish function in
EventSourceResponse.__call__ to achieve 100% interrogate coverage.

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

---------

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

IBM#2507)

Updates unique constraints for Resources and Prompts tables to support
Gateway-level namespacing. Previously, these entities enforced uniqueness
globally per Team/Owner (team_id, owner_email, uri/name). This prevented
users from registering the same Gateway multiple times with different names.

Changes:
- Add gateway_id to unique constraints for resources and prompts
- Add partial unique indexes for local items (where gateway_id IS NULL)
- Make migration idempotent with proper existence checks

Closes IBM#2352

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

…BM#2517)

* fix(transport): support mixed content types from MCP server tool call response

Closes IBM#2512

This fix addresses tool invocation failures for tools that return complex
content types (like ResourceLink, ImageContent, AudioContent) or contain
Pydantic-specific types like AnyUrl.

Root causes fixed:
1. tool_service.py: Usage of model_dump() without mode='json' preserved
   pydantic.AnyUrl objects, violating internal model's str type constraints.
2. streamablehttp_transport.py: Code blindly assumed types.TextContent,
   accessing .text on every item, which crashed for ResourceLink or ImageContent.

Changes:
- Updated tool_service.py to use model_dump(by_alias=True, mode='json'),
  forcing conversion of AnyUrl to JSON-compatible strings.
- Refactored streamablehttp_transport.py to inspect content.type and correctly
  map to proper MCP SDK types (TextContent, ImageContent, AudioContent,
  ResourceLink, EmbeddedResource) ensuring full protocol compatibility.
- Updated return type annotation to include all MCP content types.

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix(transport): preserve metadata in mixed content type conversion

Addresses dropped metadata fields identified in PR IBM#2517 review:
- Preserve annotations and _meta for TextContent, ImageContent, AudioContent
- Preserve size and _meta for ResourceLink (critical for file metadata)
- Handle EmbeddedResource via model_validate

Add comprehensive regression tests for:
- Mixed content types (text, image, audio, resource_link, embedded)
- Metadata preservation (annotations, _meta, size)
- Unknown content type fallback
- Missing optional metadata handling

Closes IBM#2512

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix(transport): convert gateway Annotations to dict for MCP SDK compatibility

mcpgateway.common.models.Annotations is a different Pydantic class from
mcp.types.Annotations. Passing gateway Annotations directly to MCP SDK
types causes ValidationError at runtime when real MCP responses include
annotations.

Fix:
- Add _convert_annotations() helper to convert gateway Annotations to dict
- Add _convert_meta() helper for consistent meta handling
- Apply conversion to all content types (text, image, audio, resource_link)

Add regression tests using actual gateway model types:
- test_call_tool_with_gateway_model_annotations
- test_call_tool_with_gateway_model_image_annotations

These tests use mcpgateway.common.models.TextContent/ImageContent with
mcpgateway.common.models.Annotations to verify the conversion works.

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* test(tool_service): add AnyUrl serialization tests for mode='json' fix

Add explicit tests for the AnyUrl serialization fix (Issue IBM#2512 root cause):
- test_anyurl_serialization_without_mode_json - demonstrates the problem
- test_anyurl_serialization_with_mode_json - verifies the fix
- test_resource_link_anyurl_serialization - ResourceLink uri field
- test_tool_result_with_resource_link_serialization - ToolResult with ResourceLink
- test_mixed_content_with_anyurl_serialization - mixed content types

These tests verify that mode='json' in model_dump() correctly serializes
AnyUrl objects to strings, preventing validation errors when content is
passed to MCP SDK types.

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* docs(transport): add docstrings to _convert_annotations and _convert_meta

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* docs(transport): add Args/Returns to helper function docstrings

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

---------

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
Co-authored-by: Mihai Criveti <crivetimihai@gmail.com>

Add user information (email, full_name, is_admin) to the plugin global
context, enabling plugins like Cedar RBAC to make access control decisions
based on user attributes beyond just email.

Changes:
- Add _inject_userinfo_instate() function to auth.py that populates
  global_context.user as a dictionary when include_user_info is enabled
- Update GlobalContext.user type to Union[str, dict] for backward compat
- Add include_user_info config option to plugin_settings (default: false)
- Prevent tool_service from overwriting user dict with string email

The feature is disabled by default to maintain backward compatibility
with existing plugins that expect global_context.user to be a string.

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
Co-authored-by: Mihai Criveti <crivetimihai@gmail.com>

Signed-off-by: Shoumi <shoumimukherjee@gmail.com>

…BM#2529)

* Add profling tools, memray

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* Add profling tools, memray

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix(db): release DB sessions before external HTTP calls to prevent pool exhaustion

This commit addresses issue IBM#2518 where DB connection pool exhaustion occurred
during A2A and RPC tool calls due to sessions being held during slow upstream
HTTP requests.

Changes:
- tool_service.py: Extract A2A agent data to local variables before calling
  db.commit(), allowing HTTP calls to proceed without holding the DB session.
  The A2A tool invocation logic now uses pre-extracted data instead of querying
  during the HTTP call phase.

- rbac.py: Add db.commit() and db.close() calls before returning user context
  in all authentication paths (proxy, anonymous, disabled auth). This ensures
  DB sessions are released early and not held during subsequent request processing.

- test_rbac.py: Update test to provide mock db parameter and verify that
  db.commit() and db.close() are called for proper session cleanup.

The fix follows the pattern established in other services: extract all needed
data from ORM objects, call db.commit() to release the transaction, then
proceed with external HTTP calls. This prevents "idle in transaction" states
that exhaust PgBouncer's connection pool under high load.

Load test results (4000 concurrent users, 1M+ requests):
- Success rate: 99.81%
- 502 errors reduced to 0.02% (edge cases with very slow upstreams)
- P50: 450ms, P95: 4300ms

Closes IBM#2518

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* perf(config): tune connection pools for high concurrency

Based on profiling with 4000 concurrent users (~2000 RPS):

- MCP_SESSION_POOL_MAX_PER_KEY: 50 → 200 (reduce session creation)
- IDLE_TRANSACTION_TIMEOUT: 120s → 300s (handle slow MCP calls)
- CLIENT_IDLE_TIMEOUT: 120s → 300s (align with transaction timeout)
- HTTPX_MAX_CONNECTIONS: 200 → 500 (more outbound capacity)
- HTTPX_MAX_KEEPALIVE_CONNECTIONS: 100 → 300
- REDIS_MAX_CONNECTIONS: 150 → 100 (stay under maxclients)

Results:
- Failure rate: 0.446% → 0.102% (4.4x improvement)
- RPC latency: 3,014ms → 1,740ms (42% faster)
- CRUD latency: 1,207ms → 508ms (58% faster)

See: todo/profile-full.md for detailed analysis
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

---------

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix(helm): stabilize chart templates and configs

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix(helm): align migration job with bootstrap

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* docs(helm): refresh chart README

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

---------

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* docs: sync env defaults and references

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* docs: sync env templates and performance tuning

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

---------

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* chore: stabilize coverage target

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* chore: reduce test warnings

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* chore: reduce test startup costs

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* chore: resolve bandit warning

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

---------

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* test(playwright): handle admin password change

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* test(playwright): stabilize admin UI flows

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

---------

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

…BM#2534)

The MCP specification does not mandate that tool names must start with
a letter - tool names are simply strings without pattern restrictions.
This fix updates the validation pattern to align with SEP-986.

Changes:
- Update VALIDATION_TOOL_NAME_PATTERN from ^[a-zA-Z][a-zA-Z0-9._-]*$
  to ^[a-zA-Z0-9_][a-zA-Z0-9._/-]*$ per SEP-986
- Allow leading underscore/number and slashes in tool names
- Remove / from HTML special characters regex (not XSS-relevant)
- Update all error messages, docstrings, and documentation
- Update tests to verify new valid cases

Tool names like `_5gpt_query_by_market_id` and `namespace/tool` are
now accepted.

Closes IBM#2528

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

…figuration (IBM#2515)

- Add passphrase-protected key support for Granian via --ssl-keyfile-password
- Add KEY_FILE_PASSWORD and CERT_PASSPHRASE compatibility in run-granian.sh
- Export KEY_FILE in run-gunicorn.sh for Python SSL manager access
- Improve Makefile cert targets with proper permissions (640) and group 0
- Split certs-passphrase into two-step generation (genrsa + req) for AES-256
- Add SSL configuration templates to nginx.conf for client and backend TLS
- Expose port 443 in NGINX Dockerfile for HTTPS support
- Update docker-compose.yml with TLS-related comments and correct cert paths
- Add comprehensive TLS configuration documentation

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
Co-authored-by: Mihai Criveti <crivetimihai@gmail.com>

…BM#2537)

During gateway activation with OAuth Authorization Code flow,
`_initialize_gateway` returns empty lists because the user hasn't
completed authorization yet. Health checks then treat these empty
responses as legitimate and delete all existing tools/resources/prompts.

This change adds an `oauth_auto_fetch_tool_flag` parameter to
`_initialize_gateway` that:

- When False (default): Returns empty lists for auth_code gateways
  during health checks, preserving existing tools
- When True (activation): Skips the early return for auth_code
  gateways, allowing activation to proceed

The existing check in `_refresh_gateway_tools_resources_prompts` at
lines 4724-4729 prevents stale deletion for auth_code gateways with
empty responses.

Fixed issues from original PR:
- Corrected typo: oath -> oauth in parameter name
- Removed duplicate docstring entry
- Fixed logic bug that incorrectly skipped token fetch for
  client_credentials flow when flag was True


Closes IBM#2272

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
Co-authored-by: Mihai Criveti <crivetimihai@gmail.com>

* feat(auth): add token revocation and proxy auth to admin middleware

- Support token revocation checks in AdminAuthMiddleware
- Enable proxy authentication for admin routes
- Filter session listings by user ownership
- Validate team membership for OAuth operations
- Add configurable public registration setting

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix(config): change token validation defaults to secure-by-default

- Set require_token_expiration default to true (was false)
- Set require_jti default to true (was false)
- Update .env.example to reflect new secure defaults

Tokens without expiration or JTI claims will now be rejected by default.
Set REQUIRE_TOKEN_EXPIRATION=false or REQUIRE_JTI=false to restore
previous behavior if needed for backward compatibility.

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* docs(security): expand securing guide with token lifecycle and access controls

Add documentation for:
- Token lifecycle management (revocation, validation settings)
- Admin route authentication requirements
- Session management access controls
- User registration configuration
- Updated production checklist with new settings

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix(auth): address SSO redirect validation and admin middleware gaps

- SSO redirect_uri validation now uses server-side allowlist only
  (allowed_origins, app_domain) instead of trusting Host header
- Full origin comparison including scheme and port to prevent
  cross-port or HTTP downgrade redirects
- AdminAuthMiddleware now supports API token authentication
- AdminAuthMiddleware now honors platform admin bootstrap when
  REQUIRE_USER_IN_DB=false for fresh deployments

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix(auth): add basic auth support to AdminAuthMiddleware

Align AdminAuthMiddleware with require_admin_auth by supporting:
- HTTP Basic authentication for legacy deployments
- Basic auth users are treated as admin (consistent with existing behavior)

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix(auth): finalize secure defaults and update changelog for RC1

- Move hashlib/base64 imports to top-level in main.py (pylint C0415)
- Add CHANGELOG entry for 1.0.0-RC1 secure defaults release
- Add Security Defaults section to .env.example
- Update test helpers to include JTI by default for REQUIRE_JTI=true

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* refactor(auth): streamline authentication model and update documentation

- Simplify Admin UI to use session-based email/password authentication
- Add API_ALLOW_BASIC_AUTH setting for granular API auth control
- Scope gateway credentials to prevent unintended forwarding
- Update 25+ documentation files for auth model clarity
- Add comprehensive test coverage for auth settings
- Fix REQUIRE_TOKEN_EXPIRATION and REQUIRE_JTI defaults in docs
- Remove BASIC_AUTH_* from Docker examples (not needed by default)

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* docs: update changelog with neutral language and ignore coverage.svg

- Reword RC1 changelog entries to use neutral language
- Add coverage.svg to .gitignore (generated by make coverage)

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

---------

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

IBM#2514)

Refactors GatewayService, ExportService, ImportService, and A2AService to use
globally-initialized service singletons (ToolService, PromptService,
ResourceService, ServerService, RootService, GatewayService) instead of
creating private, uninitialized instances.

Uses lazy singleton pattern with __getattr__ to avoid import-time instantiation
when only exception classes are imported. This ensures services are created
after logging/plugin setup is complete.

By importing the module-level services, all gateway operations now share the
same EventService/Redis client. This ensures events such as activate/deactivate
propagate correctly across workers and reach Redis subscribers.

Changes:
- Add lazy singleton pattern using __getattr__ to service modules
- Update main.py to import singletons instead of instantiating services
- Update GatewayService.__init__ to use lazy imports of singletons
- Update ExportService.__init__ to use lazy imports of singletons
- Update ImportService.__init__ to use lazy imports of singletons
- Update A2AService methods to use tool_service singleton
- Update tests to patch singleton methods instead of class instantiation
- Add pylint disables for no-name-in-module (due to __getattr__)

The fix resolves silent event drops caused by missing initialize() calls on
locally constructed services. Cross-worker UI updates and subscriber
notifications now behave as intended.

Closes IBM#2256

Signed-off-by: NAYANAR <nayana.r7813@gmail.com>
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
Co-authored-by: Mihai Criveti <crivetimihai@gmail.com>

* feat: support external plugin stdio launch options

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* feat: add streamable http uds support

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix: tidy streamable http shutdown

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* style: fix docstring line length in client.py

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix(security): harden UDS and cwd path validation

- Add canonical path resolution (.resolve()) to cwd validation to prevent
  path traversal via symlinks or relative path escapes
- Add UDS security validation:
  - Require absolute paths for Unix domain sockets
  - Verify parent directory exists
  - Warn if parent directory is world-writable (potential socket hijacking)
- Return canonical resolved paths instead of raw input
- Update tests to use tmp_path fixture for secure temp directories

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* style: fix pylint warnings in models.py

Move logging import to top level and fix implicit string concatenation.

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

---------

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

…M#2579)

* feat(infra): add zero-config TLS for nginx via Docker Compose profile

Add a new `--profile tls` Docker Compose profile that enables HTTPS
with zero configuration. Certificates are auto-generated on first run
or users can provide their own CA-signed certificates.

Features:
- One command TLS: `make compose-tls` starts with HTTPS on port 8443
- Auto-generates self-signed certs if ./certs/ is empty
- Custom certs: place cert.pem/key.pem in ./certs/ before starting
- Optional HTTP->HTTPS redirect via `make compose-tls-https`
- Environment variable NGINX_FORCE_HTTPS=true for redirect mode
- Works alongside other profiles (monitoring, benchmark)

New files:
- infra/nginx/nginx-tls.conf: TLS-enabled nginx configuration
- infra/nginx/docker-entrypoint.sh: Handles NGINX_FORCE_HTTPS env var

New Makefile targets:
- compose-tls: Start with HTTP:8080 + HTTPS:8443
- compose-tls-https: Force HTTPS redirect (HTTP->HTTPS)
- compose-tls-down: Stop TLS stack
- compose-tls-logs: Tail TLS service logs
- compose-tls-ps: Show TLS stack status

Docker Compose additions:
- cert_init service: Auto-generates certs using alpine/openssl
- nginx_tls service: TLS-enabled nginx reverse proxy

Documentation:
- Updated tls-configuration.md with Quick Start section
- Updated compose.md with TLS section
- Added to deployment navigation
- Updated README.md quick start

Closes IBM#2571

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix(nginx): use smart port detection for HTTPS redirect

Fix hard-coded :8443 port in HTTPS redirect that broke internal
container-to-container calls.

Problem:
- External access via port 8080 correctly redirected to :8443
- Internal container calls (no port) also redirected to :8443
- But nginx_tls only listens on 443 internally, so internal redirects failed

Solution:
Add a map directive that detects request origin based on Host header:
- Requests with :8080 in Host → redirect to :8443 (external)
- Requests without port → redirect without port, defaults to 443 (internal)

Tested:
- External: curl http://localhost:8080/health → https://localhost:8443/health ✓
- Internal: curl http://nginx_tls/health → https://nginx_tls/health (443) ✓

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

---------

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

…M#2582)

* fix: resolve LLM admin router db session and add favicon redirect

- Fix LLM admin router endpoints that failed with 500 errors due to
  db session being None from RBAC middleware (intentionally closed
  to prevent idle-in-transaction). Added explicit db: Session =
  Depends(get_db) to all 11 affected endpoints.

- Add /favicon.ico redirect to /static/favicon.ico for browser
  compatibility (browsers request favicon at root path).

- Update README.md Running section with clear table documenting
  the three running modes (make dev, make serve, docker-compose)
  with their respective ports, servers, and databases.

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix(llm-admin): pass kwargs to fetch_provider_models for permission check

The require_permission decorator only searches kwargs for user context.
sync_provider_models was calling fetch_provider_models with positional
args, causing the decorator to raise 401 Unauthorized.

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

---------

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* feat(testing): add JMeter performance testing baseline

Add comprehensive JMeter test plans for industry-standard performance
baseline measurements and CI/CD integration.

Test Plans (10 .jmx files):
- rest_api_baseline: REST API endpoints (1,000 RPS, 10min)
- mcp_jsonrpc_baseline: MCP JSON-RPC protocol (1,000 RPS, 15min)
- mcp_test_servers_baseline: Direct MCP server testing (2,000 RPS)
- load_test: Production load simulation (4,000 RPS, 30min)
- stress_test: Progressive stress to breaking point (10,000 RPS)
- spike_test: Traffic spike recovery (1K→10K→1K)
- soak_test: 24-hour memory leak detection (2,000 RPS)
- sse_streaming_baseline: SSE connection stability (1,000 conn)
- websocket_baseline: WebSocket performance (500 conn)
- admin_ui_baseline: Admin UI user simulation (50 users)

Infrastructure:
- 12 Makefile targets for running tests and generating reports
- Properties files for production and CI environments
- CSV test data for parameterized testing
- Performance SLAs documentation (P50/P95/P99 latencies)

Closes IBM#2541

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix(testing): improve JMeter testing setup and fix test issues

- Add jmeter-install target to download JMeter 5.6.3 locally
- Add jmeter-ui target to launch JMeter GUI
- Add jmeter-check to verify JMeter 5.x+ (required for -e -o flags)
- Add jmeter-clean target to clean results directory
- Fix jmeter-report to handle empty results gracefully
- Fix load_test.jmx JEXL3 thread count expressions
- Fix admin_ui_baseline.jmx HTMX endpoint paths
- Add HTTPS/TLS testing documentation and configuration
- Add .jmeter/ to .gitignore for local installation

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix(testing): fix JMeter JWT auth and add linter fixes

- Fix JMETER_TOKEN generation: use python3 instead of python
- Add JMETER_JWT_SECRET with default value (my-test-key)
- Add encoding headers and fix import formatting from linter

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* feat(testing): add jmeter-quick target for fast test verification

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

---------

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

)

- Add .envrc for direnv support
- Remove 14+ duplicate/redundant patterns
- Reorganize with clear section comments
- Add missing patterns (.ica.env, pip-log.txt, pip-delete-this-directory.txt)

Signed-off-by: Adnan Vahora <adnanvahora114@gmail.com>

* feat(plugins): add TOON encoder plugin for token-efficient responses

Add a tool_post_invoke plugin that converts JSON tool results to TOON
(Token-Oriented Object Notation) format, achieving 30-70% token reduction.

Features:
- Pure Python TOON encoder/decoder per spec v3.0
- Configurable size thresholds and tool filtering
- Format markers for downstream parsing
- Graceful error handling with skip_on_error fallback
- Columnar format for homogeneous object arrays

Closes IBM#2574

Signed-off-by: Joe Stein <joe.stein@sscinc.com>
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* lint

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* docs(toon): document alternative delimiter limitation

Add documentation about tab/pipe delimiter limitation in columnar
array headers. The TOON spec v3.0 allows alternative delimiters,
which our regex matches but decoder doesn't parse correctly (always
splits on commas). Document this as a known decoder limitation.

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* feat(toon): support tab/pipe delimiters in columnar arrays

Add support for alternative delimiters (tab, pipe) in columnar array
headers per TOON spec v3.0. The decoder now detects the delimiter from
the header and uses it consistently for parsing row values.

- Add _detect_delimiter() function to identify delimiter from header
- Update _decode_columnar_array() to accept and use delimiter parameter
- Update _split_row_values() to split on configurable delimiter
- Add tests for pipe and tab delimiter decoding
- Remove limitation from README (now fully supported)

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix(toon): remove unused import and variable

- Remove unused Union import (F401)
- Remove unused ind variable in _encode_array (F841)

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix(toon): prefix unused parameters with underscore

Silence vulture warnings by prefixing intentionally unused parameters:
- _as_root in _encode_array and _encode_object (for API consistency)
- _expected_count in _split_row_values (for potential validation)
- _context in tool_post_invoke (required by plugin interface)

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix(admin): return disabled plugin details in View Details

get_plugin_by_name() only checked the registry for enabled plugins,
causing "Not Found" errors when clicking View Details on disabled
plugins. Now falls back to checking config.plugins for disabled
plugins, matching the behavior of get_all_plugins().

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

---------

Signed-off-by: Joe Stein <joe.stein@sscinc.com>
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
Co-authored-by: Mihai Criveti <crivetimihai@gmail.com>

- allow overriding the python runtime for external plugins
- reset plugin registry before re-init to avoid stale entries
- normalize resource/service tag lists to strings

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

…BM#2605)

Add 409 to allowed response codes for state change endpoints in the
Locust load test. Under high concurrency, 409 Conflict is expected
behavior due to optimistic locking when multiple users try to toggle
the same entity's state simultaneously.

Updated endpoints:
- set_server_state() - /servers/[id]/state
- set_tool_state() - /tools/[id]/state
- set_resource_state() - /resources/[id]/state
- set_prompt_state() - /prompts/[id]/state
- set_gateway_state() - /gateways/[id]/state

Closes IBM#2566

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* test: expand coverage unit tests and plan

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* chore: remove local test plan from repo

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

---------

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* docs: rationalize README and move detailed content to docs

- Reduce README from 2,502 to 960 lines (-62%)
- Add Quick Links section linking to pinned issues (IBM#2502, IBM#2503, IBM#2504)
- Move environment variables to docs/docs/manage/configuration.md
- Create docs/docs/manage/troubleshooting.md with detailed guides
- Add VS Code Dev Container section to developer-onboarding.md
- Use <details> collapsibles for advanced Docker/Podman/PostgreSQL content
- Streamline Configuration section to essential variables only
- Update version reference from v0.9.0 to 1.0.0-BETA-2
- Verify all 15 ToC anchors and 17 external doc links

Closes IBM#2365

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* chore(docs): bump documentation dependency versions

- mkdocs-git-revision-date-localized-plugin: 1.5.0 → 1.5.1
- mkdocs-include-markdown-plugin: 7.2.0 → 7.2.1
- pathspec: 1.0.3 → 1.0.4

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix(docs): add missing blank lines before tables in index.md

MkDocs requires blank lines between bold headers and tables for
proper rendering. Fixed SSO configuration sections.

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* docs: streamline docs landing page and fix broken links

- Replace verbose docs/docs/index.md with streamlined content matching README
- Convert GitHub-flavored <details> to MkDocs ??? admonitions
- Use relative links for internal navigation
- Fix broken #configuration-env-or-env-vars anchors in:
  - docs/docs/development/index.md
  - docs/docs/manage/securing.md
- Reduce docs landing page from 2,603 to 678 lines (-74%)

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

---------

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

…BM#3111)

* fix: visibility and admin scope hardening and behavior consistency (C-22 C-24 C-27 C-32 C-23)

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* chore: docstring completeness hardening and behavior consistency

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* test: scope regression coverage hardening and behavior consistency

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix: streamable completion scope hardening and behavior consistency (C-24)

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* test: completion scope branch coverage hardening in rpc and protocol paths

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

---------

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

…M#3114)

* fix: oauth grant handling hardening and behavior consistency (O-11)

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix: sso flow validation hardening and behavior consistency (O-03 O-04 O-06 O-14)

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix: oauth access enforcement hardening and behavior consistency (O-02 O-15 O-16)

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* chore: auth lint compliance hardening and behavior consistency

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* docs: rc2 changelog and sso approval flow consistency

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix: oauth status request-context hardening (O-16)

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* test: expand oauth and sso hardening regression coverage

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix: github sso email-claim handling and regression coverage

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix: oauth fetch-tools access hardening (O-15)

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* Update tests

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

---------

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

…utbound URL validation (h-batch-6) (IBM#3115)

* fix: oauth config hardening and behavior consistency

Refs: A-02, A-05, O-10, O-17

- centralize oauth secret protection for service-layer CRUD

- add server oauth masking parity for read/list responses

- keep oauth secret decrypt to runtime token exchange paths

- expand regression coverage for encryption and masking behavior

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix: email auth timing hardening and behavior consistency

Refs: A-06

- add dummy password verification on early login failures

- enforce configurable minimum failed-login response duration

- add focused regression tests for timing guard paths

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix: outbound url validation hardening and behavior consistency

Refs: S-02, S-03

- validate admin gateway test base URL before outbound requests

- validate llmchat connect server URL before session setup

- add regression tests for strict local/private URL rejection

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* test: regression coverage hardening and behavior consistency

Refs: A-02, A-05, A-06, O-10, O-17

- add branch-focused regression tests for oauth secret handling and runtime decrypt guards

- add legacy update-object coverage for server oauth update path

- align helper docstrings with linting policy requirements

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* Update tests

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix: hardening consistency for oauth storage, auth timing, and SSRF validation (A-02 A-05 A-06 O-10 O-17 S-02 S-03)

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix: harden admin endpoints and align load-test payloads

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

---------

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

…M#3120)

* fix: llm proxy hardening and behavior consistency

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* Update AGENTS.md

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* chore: lint docstring hardening and behavior consistency

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix: harden alembic sqlite migration compatibility

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix: tighten llm token scoping and update rbac docs

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

---------

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

- Update DCR service test for new client name format
- Fix metrics service default expectations (recording/aggregation disabled by default)
- Add autouse fixtures to enable metrics for test classes
- Fix resource subscribe test to expect actual user data instead of None

All tests now pass (0 failures)

Signed-off-by: yiannis2804 <yiannis2804@gmail.com>

- Remove trailing whitespace from all modified files
- Fix HttpHeaderPayload to use root= keyword argument (pylint)
- Fix test expectations for settings defaults
- Update DCR service test for new client name
- Fix resource subscribe test for actual user data

Signed-off-by: yiannis2804 <yiannis2804@gmail.com>

- Add teams=None and is_admin=True to JWT token for admin bypass
- Update mock_get_current_user_with_permissions to include permissions
- Fix RPC test expectations for user_email and token_teams (None instead of values)
- Fix resource subscribe test expectation

Signed-off-by: yiannis2804 <yiannis2804@gmail.com>

- Fix test_init_custom_values to assert False (matches passed value)
- Use ANY matcher for user_email and token_teams in RPC tests
- These values differ between local (None) and CI (actual values) environments

Signed-off-by: yiannis2804 <yiannis2804@gmail.com>