-
Notifications
You must be signed in to change notification settings - Fork 615
[CHORE] workflow_dispatch platforms input is unused in docker-multiplatform.yml #2207
Copy link
Copy link
Closed
Copy link
Labels
SHOULDP2: Important but not vital; high-value items that are not crucial for the immediate releaseP2: Important but not vital; high-value items that are not crucial for the immediate releasechoreLinting, formatting, dependency hygiene, or project maintenance choresLinting, formatting, dependency hygiene, or project maintenance chorescicdIssue with CI/CD process (GitHub Actions, scaffolding)Issue with CI/CD process (GitHub Actions, scaffolding)devopsDevOps activities (containers, automation, deployment, makefiles, etc)DevOps activities (containers, automation, deployment, makefiles, etc)good first issueGood for newcomersGood for newcomers
Milestone
Description
Summary
The workflow_dispatch trigger in .github/workflows/docker-multiplatform.yml defines a platforms input that allows specifying which platforms to build, but this input is never used. The build matrix and manifest creation are hardcoded.
Current Behavior
workflow_dispatch:
inputs:
platforms:
description: 'Platforms to build (comma-separated)'
required: false
default: 'linux/amd64,linux/arm64,linux/s390x,linux/ppc64le'However:
- The build matrix at line 67-85 is hardcoded with all platforms
- The manifest step at lines 191-194 hardcodes all four architecture tags
This means:
- Manual workflow runs cannot skip slow QEMU builds (s390x, ppc64le take ~30-45 min each)
- If a subset is intended, the manifest step will fail looking for missing tags
Expected Behavior
The platforms input should control which platforms are built and included in the manifest, allowing users to:
- Run quick builds with just
linux/amd64for testing - Skip QEMU-emulated builds when not needed
- Build any subset of supported platforms
Proposed Solution
Options to consider:
- Dynamic matrix generation - Use a job to parse the
platformsinput and generate the matrix dynamically - Remove the input - If dynamic selection isn't needed, remove the unused input to avoid confusion
- Conditional matrix includes - Use
ifconditions on matrix entries based on input
Files Affected
.github/workflows/docker-multiplatform.yml(lines 41-46, 67-85, 187-194)
Priority
Low - This is a usability enhancement, not a bug. The workflow functions correctly for its primary use case (building all platforms on push/PR/schedule).
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
SHOULDP2: Important but not vital; high-value items that are not crucial for the immediate releaseP2: Important but not vital; high-value items that are not crucial for the immediate releasechoreLinting, formatting, dependency hygiene, or project maintenance choresLinting, formatting, dependency hygiene, or project maintenance chorescicdIssue with CI/CD process (GitHub Actions, scaffolding)Issue with CI/CD process (GitHub Actions, scaffolding)devopsDevOps activities (containers, automation, deployment, makefiles, etc)DevOps activities (containers, automation, deployment, makefiles, etc)good first issueGood for newcomersGood for newcomers