-
Notifications
You must be signed in to change notification settings - Fork 613
[FEATURE][BUILD]: Support for container builds for s390xΒ #1138
Description
π§ Type of Feature
Enhancement to existing functionality: Enhance the current container build tools to include changes needed to support container build on s390x architecture.
π§ Epic
Title: Enhance container build scripts to support s390x
Goal: Consistent container build process regardless of platform architecture
Why now: Depend build capability needed for s390x as part of ability to provide multi-arch container images.
πβοΈ User Story 1
As a: Developer
I want: The MCP gateway Docker image to support s390x architecture
So that: I can run deploy and run MCP gateway on s390x without having to build the container locally.
β Acceptance Criteria
Scenario: Update existing container build scripts as needed to support s390x
Given a developer is running on s390x or using emulation
When Allow "make build-container" to build for s390x architecture as a user can do on any other architecture
Then Successfully build a container image for s390x without customer modifications
πβοΈ User Story 2
As a: Developer
I want: to ensure that the introduction of s390x is supported by buildha/podman and docker build
So that: existing build/runtime tools remain consistent across architectures
β Acceptance Criteria
Scenario: Validate that build and runtime of a container is consistent between docker and podman.
Given that docker and podman are already integrated into the build scripts for other platforms.
When a developer wishes to build a container for s390x.
Then Successfully build a container image for s390x without errorsπ Design Sketch (optional)
Include a diagram, sketch, or flow (use Mermaid if desired):
flowchart TD
A[Client] -->|POST /completions| B(MCPGateway)
B --> C[Completion Service]
π MCP Standards Check
- Change adheres to current MCP specifications
- No breaking changes to existing MCP-compliant integrations
π Alternatives Considered
make compiler flag to include specific changes needed in container builds for s390x
Changes only to Makefile where not sufficient because of the way multi-arch container builds are built.
π Additional Context
Adding s390x support includes a minimal set of changes to the build scripts in a way that does not alter existing architectures.