Improve error message for from_type(Type["int"])#2892
Merged
Zac-HD merged 2 commits intoHypothesisWorks:masterfrom Mar 9, 2021
Merged
Improve error message for from_type(Type["int"])#2892Zac-HD merged 2 commits intoHypothesisWorks:masterfrom
from_type(Type["int"])#2892Zac-HD merged 2 commits intoHypothesisWorks:masterfrom
Conversation
sobolevn
reviewed
Mar 8, 2021
Member
sobolevn
left a comment
There was a problem hiding this comment.
Thank you! 👍
Sadly, the ForwardRef implementation is far from ideal 😞
bd6f2a0 to
fdabf59
Compare
This was referenced Mar 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sadly this closes #2565, because
Typeobjects don't track the module they were defined in - and we therefore can't get the globals in which to look up the forward reference.Upside, at least I managed to improve the error message and write a covering test 😕