Add containerPort option to avoid using HTTPS port 443 for plain HTTP#4
Merged
gwdp merged 2 commits intoHybridless:masterfrom Oct 28, 2021
Merged
Add containerPort option to avoid using HTTPS port 443 for plain HTTP#4gwdp merged 2 commits intoHybridless:masterfrom
gwdp merged 2 commits intoHybridless:masterfrom
Conversation
gwdp
approved these changes
Oct 28, 2021
Contributor
|
Since we are talking about the port used between the ALB and the container I always had the assumption you could map out the container port to be 443 independently of the protocol, but you are totally right, there are use cases where we could want to route to a different port. Building and bumping npm later tonight. Really thanks for the contribution, appreciate it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was confused by HTTPS port 443 being used also as
containerPortwith plain HTTP traffic.Seeing that health checks fail trying to access my docker image via port 443, while it expects port 8080, lead me to adding
containerPortoption to this plugin copy to clearly haveport: 443for HTTPS ALB listener andcontainerPort: 8080for HTTP inTargetGroupand ECS container, to see clear SSL unwrapping happening at ALB.Later I discovered the true reason of health check failure was the issue #2 I reported, so please fix that issue first.
But to avoid further confusion of other users of this plugin regarding
HTTPS port != HTTP containerPort, please also review and merge this PR