Skip to content

Commit 1a60020

Browse files
committed
Revert "use the class configuration from the cache"
This reverts commit 4f6ca24.
1 parent 4f6ca24 commit 1a60020

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

src/main/java/org/htmlunit/javascript/RecursiveFunctionObject.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@
2323
import org.htmlunit.corejs.javascript.FunctionObject;
2424
import org.htmlunit.corejs.javascript.Scriptable;
2525
import org.htmlunit.corejs.javascript.ScriptableObject;
26+
import org.htmlunit.javascript.configuration.AbstractJavaScriptConfiguration;
2627
import org.htmlunit.javascript.configuration.ClassConfiguration;
2728
import org.htmlunit.javascript.configuration.ClassConfiguration.ConstantInfo;
28-
import org.htmlunit.javascript.configuration.JavaScriptConfiguration;
2929

3030
/**
3131
* A FunctionObject that returns IDs of this object and all its parent classes.
@@ -103,8 +103,8 @@ public Object get(final String name, final Scriptable start) {
103103
Class<?> klass = getPrototypeProperty().getClass();
104104

105105
while (value == NOT_FOUND && HtmlUnitScriptable.class.isAssignableFrom(klass)) {
106-
final ClassConfiguration config = JavaScriptConfiguration.getInstance(browserVersion_)
107-
.getClassConfiguration(klass.getName());
106+
final ClassConfiguration config = AbstractJavaScriptConfiguration.getClassConfiguration(
107+
klass.asSubclass(HtmlUnitScriptable.class), browserVersion_);
108108
if (config != null) {
109109
final List<ConstantInfo> constants = config.getConstants();
110110
if (constants != null) {

src/main/java/org/htmlunit/javascript/host/intl/Intl.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222
import org.htmlunit.javascript.HtmlUnitScriptable;
2323
import org.htmlunit.javascript.JavaScriptEngine;
2424
import org.htmlunit.javascript.RecursiveFunctionObject;
25+
import org.htmlunit.javascript.configuration.AbstractJavaScriptConfiguration;
2526
import org.htmlunit.javascript.configuration.ClassConfiguration;
26-
import org.htmlunit.javascript.configuration.JavaScriptConfiguration;
2727

2828
/**
2929
* A JavaScript object for {@code Intl}.
@@ -47,8 +47,7 @@ public void defineProperties(final BrowserVersion browserVersion) {
4747

4848
private void define(final Class<? extends HtmlUnitScriptable> c, final BrowserVersion browserVersion) {
4949
try {
50-
final ClassConfiguration config = JavaScriptConfiguration.getInstance(browserVersion)
51-
.getClassConfiguration(c.getName());
50+
final ClassConfiguration config = AbstractJavaScriptConfiguration.getClassConfiguration(c, browserVersion);
5251
final HtmlUnitScriptable prototype = JavaScriptEngine.configureClass(config, this);
5352
final FunctionObject functionObject =
5453
new RecursiveFunctionObject(config.getJsConstructor().getKey(),

src/main/java/org/htmlunit/javascript/host/worker/DedicatedWorkerGlobalScope.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@
4040
import org.htmlunit.javascript.RecursiveFunctionObject;
4141
import org.htmlunit.javascript.background.BasicJavaScriptJob;
4242
import org.htmlunit.javascript.background.JavaScriptJob;
43+
import org.htmlunit.javascript.configuration.AbstractJavaScriptConfiguration;
4344
import org.htmlunit.javascript.configuration.ClassConfiguration;
44-
import org.htmlunit.javascript.configuration.JavaScriptConfiguration;
4545
import org.htmlunit.javascript.configuration.JsxClass;
4646
import org.htmlunit.javascript.configuration.JsxConstructor;
4747
import org.htmlunit.javascript.configuration.JsxFunction;
@@ -121,12 +121,13 @@ public void jsConstructor() {
121121
context.initSafeStandardObjects(this);
122122
JavaScriptEngine.configureRhino(webClient, browserVersion, this);
123123

124-
final JavaScriptConfiguration jsConfig = JavaScriptConfiguration.getInstance(browserVersion);
125-
ClassConfiguration config =
126-
jsConfig.getClassConfiguration(DedicatedWorkerGlobalScope.class.getSuperclass().getName());
124+
ClassConfiguration config = AbstractJavaScriptConfiguration.getClassConfiguration(
125+
(Class<? extends HtmlUnitScriptable>) DedicatedWorkerGlobalScope.class.getSuperclass(),
126+
browserVersion);
127127
final HtmlUnitScriptable parentPrototype = JavaScriptEngine.configureClass(config, this);
128128

129-
config = jsConfig.getClassConfiguration(DedicatedWorkerGlobalScope.class.getName());
129+
config = AbstractJavaScriptConfiguration.getClassConfiguration(
130+
DedicatedWorkerGlobalScope.class, browserVersion);
130131
final HtmlUnitScriptable prototype = JavaScriptEngine.configureClass(config, this);
131132
prototype.setPrototype(parentPrototype);
132133
setPrototype(prototype);

0 commit comments

Comments
 (0)